Ubuntu
ubuntu-push package

push notification ignoring silent mode

Bug #1426418 reported by Bill Filler
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu Push Notifications
Fix Released
High
John Lenton
ubuntu-push (Ubuntu)
Fix Released
High
John Lenton

Bug Description

vivid proposed build 112

- go to system settings->sounds and set Silent Mode to true
- recv a push notification from gmail or telegram

Expected results:
- the notification should appear but it should not make a sound

Actual results:
- the notification appears but the sound is still heard

This seems to work correctly in rtm but not in vivid so it's possible something didn't land in vivid perhaps?

Related branches

lp:~chipaca/ubuntu-push/use-of-accounts
Samuele Pedroni: Approve
Diff: 411 lines (+124/-15)
6 files modified
bus/haptic/haptic.go (+9/-2)
bus/haptic/haptic_test.go (+35/-6)
client/service/postal.go (+12/-2)
client/service/postal_test.go (+9/-0)
sounds/sounds.go (+15/-2)
sounds/sounds_test.go (+44/-3)
lp:ubuntu/vivid-proposed/ubuntu-push
Bill Filler (bfiller)
Changed in ubuntu-push (Ubuntu):
importance: Undecided → High
assignee: nobody → John Lenton (chipaca)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-push (Ubuntu):
status: New → Confirmed
Revision history for this message
Ken VanDine (ken-vandine) wrote :

I've reproduced this on vivid proposed build 114 as well. I've confirmed the setting is changing in accountsservice, but still getting the beep from push notifications.

gdbus introspect --system -d org.freedesktop.Accounts -o /org/freedesktop/Accounts/User`id -u phablet`|grep -A21 com.ubuntu.touch.AccountsService.Sound
  interface com.ubuntu.touch.AccountsService.Sound {
    methods:
    signals:
    properties:
      @org.freedesktop.Accounts.DefaultValue("false")
      readwrite b SilentMode = true;
      @org.freedesktop.Accounts.DefaultValue.String("/usr/share/sounds/ubuntu/ringtones/Ubuntu.ogg")
      readwrite s IncomingCallSound = '/usr/share/sounds/ubuntu/ringtones/Ubuntu.ogg';
      @org.freedesktop.Accounts.DefaultValue.String("/usr/share/sounds/ubuntu/notifications/Xylo.ogg")
      readwrite s IncomingMessageSound = '/usr/share/sounds/ubuntu/notifications/Xylo.ogg';
      @org.freedesktop.Accounts.DefaultValue("true")
      readwrite b IncomingCallVibrate = true;
      @org.freedesktop.Accounts.DefaultValue("true")
      readwrite b IncomingCallVibrateSilentMode = true;
      @org.freedesktop.Accounts.DefaultValue("true")
      readwrite b IncomingMessageVibrate = true;
      @org.freedesktop.Accounts.DefaultValue("true")
      readwrite b IncomingMessageVibrateSilentMode = true;
      @org.freedesktop.Accounts.DefaultValue("true")
      readwrite b OtherVibrate = true;
      @org.freedesktop.Accounts.DefaultValue("true")
      readwrite b DialpadSoundsEnabled = true;

Revision history for this message
John Lenton (chipaca) wrote :

push is setting the right PULSE_PROP, so maybe it's not being picked up?

I'll chase it down; thanks for the heads up.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

The currently implementation is still not connected with pulseaudio (it's up to the clients to check for the silent mode config value and decide to not play the file).

This will move in the future to be connected with pulse in a way that it could, by itself, play or not the file if the system-wide config is enabled (which would be basically a mute at an specific role, such as alert).

John Lenton (chipaca)
Changed in ubuntu-push:
assignee: nobody → John Lenton (chipaca)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-push - 0.68+15.04.20150306.2-0ubuntu1

---------------
ubuntu-push (0.68+15.04.20150306.2-0ubuntu1) vivid; urgency=medium

  [ John R. Lenton ]
  * Use settings from org.freedesktop.Accounts for silent mode, when to
    vibrate, and default sound. [client] (LP: #1426418, LP: #1427702)

  [ Samuele "Yak Shaver of the Year" Pedroni ]
  * Closing webchecker (avoids leaving goroutines around in testing). [client]
  * WatchSignal cancelling, and connectivity exposed cancelling, make
    connectivity start not leave watches behind (more goroutine
    cleanup). [client]
  * TestTakeTheBusWorks doesn't block anymore, fixed leaking of
    webcheckers. [client]
 -- CI Train Bot <email address hidden> Fri, 06 Mar 2015 13:27:06 +0000

Changed in ubuntu-push (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

bookkepping

Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww13-ota
status: New → Fix Released
Pat McGowan (pat-mcgowan)
no longer affects: canonical-devices-system-image
John Lenton (chipaca)
Changed in ubuntu-push:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.