Mahara

ID tags needed on Edit Access and secret URL's on shared by me

Bug #1427845 reported by Jinelle Foley-Barnes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 15.04.0

Bug Description

Hi,

When Behat goes to Portfolio-> Shared by Me and tries clicking on the Edit access and Secret URL's images it currently cant differentiate between them all because the alt tags are the same for them respectively.

This becomes an issue when you have multiple pages in your portfolio.

I have pushed a test to Gerrit, and when this bug is fixed the test will run.

Thank you,
Jinelle

Tags: behat
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4344

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4345

Aaron Wells (u-aaronw)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4345
Committed: http://gitorious.org/mahara/mahara/commit/769d117fae38241d883723e624a4791d5a6d0dc6
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 769d117fae38241d883723e624a4791d5a6d0dc6
Author: Robert Lyon <email address hidden>
Date: Wed Mar 4 10:35:00 2015 +1300

Adding ids to the edit access and secret url edit buttons

Bug #1427845

the ids are in the form of:
editaccess_{id of view}
secreturl_{id of view}

eg for view id=10 it will be editaccess_10 and secreturl_10

Signed-off-by: Robert Lyon <email address hidden>

Change-Id: I9b86a39db9a56d295d659203a9c8c1b4b4ba5e5e

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4344
Committed: http://gitorious.org/mahara/mahara/commit/85bd2d464befbb49073b0220b97d7b4851619804
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 85bd2d464befbb49073b0220b97d7b4851619804
Author: Eduardo Schicker <email address hidden>
Date: Wed Mar 4 09:58:15 2015 +1300

Behat Test: Secret URL access button (Bug 1426983)

This test has one broken step it cant identify the secret url button because there's no ID. (See Bug 1427845)

Change-Id: Id0e65f3f40c980813eb7ffadf6665c22c164afff
Signed-off-by: Jinelle Foley-Barnes <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.