[MIR] media-hub

Waiting https://code.launchpad.net/~rsalveti/media-hub/migrating-tests-open-formats/+merge/251669 to land before subscribing the ubuntu-mir team.

Didier, do you happen to have time for this review?

* qtelepathy-qt5:

debian/rules:
- any change someone spend some time to look at the races in the failing tests and run them? (at least as adt tests).
- optional, but please consider using dh_install --fail-missing instead of --list-missing and rm in debian/tmp the file you don't want to install, that helps controlling and ensuring we are building everything we need.

debian/control: it's weird to have a build-depend as a metapackage (qt5-default), didn't we evolve the policy for other Qt5 packages IIRC, like depending on qtbase5-dev?

Otherwise, this package looks good.

* media-hub:
debian/control:
# We rely on C++11 features, and to prevent from ABI breaks
# in libstdc++ causing us issues, we explicitly select a G++
# version.
               g++-4.9,
-> is that still the case nowdays? I thought g++ stabilized their C++11 features ABI-break wise. Note for myself: this is also hardcoded in debian/rules.

Package: media-hub pre-depends on dpkg, but isn't multi-arch or any postinst use any "more recent" dpkg features, can that be cleaned up? (I think even the other pre-depends on libmedia-hub* can be cleaned up now that trusty is out)

I assume the security team already got a security pass at it?

Apart from those nitpicks, looking good, keep me posted about the questions :)

I don't think media-hub needs a security audit. We've reviewed the apparmor integration already and the other parts just need a normal MIR review.

On Mon, Mar 9, 2015 at 1:38 PM, Didier Roche <email address hidden> wrote:
> * qtelepathy-qt5:
>
> debian/rules:
> - any change someone spend some time to look at the races in the failing tests and run them? (at least as adt tests).

This needs quite a bit of work, specially because it was disabled with
0.2.0-2 (and after enabling it again it seems the problems are still
there). Will ask Tiago and Boiko to take a look to see if they can at
least add that to their backlog.

> - optional, but please consider using dh_install --fail-missing instead of --list-missing and rm in debian/tmp the file you don't want to install, that helps controlling and ensuring we are building everything we need.

Done

> debian/control: it's weird to have a build-depend as a metapackage
> (qt5-default), didn't we evolve the policy for other Qt5 packages IIRC,
> like depending on qtbase5-dev?

It's still required afaik, and that is still true for quite a few
other packages (just check the reverse-depends on it).

> Otherwise, this package looks good.
>
> * media-hub:
> debian/control:
> # We rely on C++11 features, and to prevent from ABI breaks
> # in libstdc++ causing us issues, we explicitly select a G++
> # version.
> g++-4.9,
> -> is that still the case nowdays? I thought g++ stabilized their C++11 features ABI-break wise. Note for myself: this is also hardcoded in debian/rules.

Yes, after fighting with some really obscure issues during this cycle
we decided it's just better to force the compiler version, so I'd
prefer us to keep it.

> Package: media-hub pre-depends on dpkg, but isn't multi-arch or any
> postinst use any "more recent" dpkg features, can that be cleaned up? (I
> think even the other pre-depends on libmedia-hub* can be cleaned up now
> that trusty is out)

Done.

> I assume the security team already got a security pass at it?
>
> Apart from those nitpicks, looking good, keep me posted about the
> questions :)

Great, let me know if you need anything.

Thanks for poking upstream about their testsuites, please track it :)

With that and the changes, looks good to me, do not hesitate to poke for the actual promotion once needed.

Adjusted overrides for media-hub for oxide-qt in the ubuntu-mozilla-security ppa.

Adjusted overrides for telepathy-qt5 for oxide-qt in the ubuntu-mozilla-security ppa.

To clarify: I adjusted the overrides in wily for the aforementioned packages so that the oxide-qt in the ubuntu-mozilla-security ppa could build.