Download zip file of home folder, can't be extracted in Windows

Hi Bernard

Hmm, I've tried to replicate and have not being able to. Can you let me know the program you use to try and unzip the compressed file and what version it is?

Cheers

Robert

Hi Robert,

I'm using the built in Windows extraction functionality; I've tried two computers (both Windows7) and the same error occurs on both. Its just happening on the home folder though.

Thanks.

Hi Bernard,

What web server software are you using? Is that on Windows as well?

I'll try to test this bug out tomorrow on our Windows test laptop at Mahara HQ.

Cheers,
Aaron

Hi Aaron,

I was using the Mahara test instance:
http://master.dev.mahara.org/

Thanks

I confirmed this as well.

Test prodedure:

1. Clean Mahara install
2. Go to Content -> Files
3. Upload a file into the top level of your files area
4. Click "Download folder content as a zip file"
5. Try to open it with Windows' built-in zip handler (i.e. tell the browser to open it, or right-click and select "Extract all")

Expected result: The zip file should unzip with the single file in it
Actual result: The zip file opens up and appears empty, or you get an "Invalid file" message

A few more details:
- The top-level zip file worked fine in Linux, and WinRar
- The built-in Windows zip extractor works fine for other Mahara folders downloaded as zip. It's only the top-level one that causes problems.

It also the same problem if I follow the test procedure on my Linux desktop, take the zip file on a thumb drive, and try to open it in Windows.

If I take that zip file that doesn't work in Windows, unzip it in Linux, and then re-zip it in Linux so that I have a new zip file with exactly the same contents, *that* one works in Windows.

So it's something in the format of our zip files for zips of the top-level file directory, as we generate them in PHP. I ran "zip -T" on one of these, and it didn't detect any problems.

Ah, I see the problem.

aaronw@vegas:~/Downloads$ unzip -l folder-home.zip
Archive: folder-home.zip
  Length Date Time Name
--------- ---------- ----- ----
    17977 2015-04-16 13:50 /pikachu.jpg
--------- -------
    17977 1 file
aaronw@vegas:~/Downloads$ unzip -l pikachu.jpg.zip
Archive: pikachu.jpg.zip
  Length Date Time Name
--------- ---------- ----- ----
    17977 2015-04-16 13:50 pikachu.jpg
--------- -------
    17977 1 file

We're generating the name of the file as "/pikachu.jpg". Linux can deal with this, but Windows cannot.

Patch for "master" branch: https://reviews.mahara.org/5233

Reviewed: https://reviews.mahara.org/5233
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/27f1a5f2a77ff2492579a4468a855de535c89cc1
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 27f1a5f2a77ff2492579a4468a855de535c89cc1
Author: Son Nguyen <email address hidden>
Date: Tue Sep 8 12:47:45 2015 +1200

Remove the top '/' when downloading the home folder. Bug 1437083

behatnotneeded

Change-Id: I12f3be46df1042a77f719be9ae8dcec535f3959a

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5452

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5453

Reviewed: https://reviews.mahara.org/5453
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d227b1abce39e925d9671cd172750c59bbe6e05b
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit d227b1abce39e925d9671cd172750c59bbe6e05b
Author: Son Nguyen <email address hidden>
Date: Tue Sep 8 12:47:45 2015 +1200

Remove the top '/' when downloading the home folder. Bug 1437083

behatnotneeded

Change-Id: I12f3be46df1042a77f719be9ae8dcec535f3959a
(cherry picked from commit 27f1a5f2a77ff2492579a4468a855de535c89cc1)

Reviewed: https://reviews.mahara.org/5452
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2a4d41aa44f8f81f4b41b9c7be685a7cd889dd6b
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 2a4d41aa44f8f81f4b41b9c7be685a7cd889dd6b
Author: Son Nguyen <email address hidden>
Date: Tue Sep 8 12:47:45 2015 +1200

Remove the top '/' when downloading the home folder. Bug 1437083

behatnotneeded

Change-Id: I12f3be46df1042a77f719be9ae8dcec535f3959a
(cherry picked from commit 27f1a5f2a77ff2492579a4468a855de535c89cc1)