Ubuntu
ofono package

In case there is no type field in APN, we should provision for all types

Bug #1437200 reported by Alfonso Sanchez-Beato
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Undecided
Unassigned
ofono (Ubuntu)
Fix Released
High
Alfonso Sanchez-Beato

Bug Description

In case there there is no "type" field for an entry in the Android APN DB, we should provision all possible types for that entry. In those cases, the type is set to PhoneConstants.APN_TYPE_ALL in the Android code. See:

http://androidxref.com/4.4.2_r1/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/dataconnection/DcTracker.java#844

http://androidxref.com/4.4.2_r1/xref/frameworks/base/telephony/java/com/android/internal/telephony/PhoneConstants.java#110

http://androidxref.com/5.1.0_r1/xref/frameworks/opt/telephony/src/java/com/android/internal/telephony/dataconnection/ApnSetting.java#307

As PhoneConstants.APN_TYPE_ALL="*", in case we find a type="*" in the DB we must treat it also as an entry valid for all types (I have actually seen type="*" in a Moto G APN DB).

See original description

Related branches

lp:~phablet-team/ofono/ww13-update
Ricardo Salveti (community): Approve
Alfonso Sanchez-Beato: Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 1314 lines (+686/-110)
16 files modified
debian/changelog (+19/-0)
doc/connman-api.txt (+8/-0)
drivers/mtkmodem/mtkrequest.h (+2/-2)
drivers/mtkmodem/mtkunsol.c (+35/-0)
drivers/mtkmodem/mtkunsol.h (+7/-0)
drivers/rilmodem/gprs-context.c (+9/-3)
gril/grilunsol.c (+75/-17)
include/modem.h (+5/-0)
plugins/bluetooth.c (+10/-0)
plugins/mtk.c (+326/-75)
plugins/ubuntu-apndb.c (+9/-10)
src/common.c (+1/-1)
src/gprs.c (+104/-1)
src/modem.c (+8/-0)
unit/test-common.c (+1/-1)
unit/test-mtkunsol.c (+67/-0)
lp:ubuntu/vivid-proposed/ofono
Alfonso Sanchez-Beato (alfonsosanchezbeato)
description: updated
description: updated
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

This PR fixes the bug:

https://github.com/rilmodem/ofono/pull/172

Tony Espy (awe)
Changed in ofono (Ubuntu):
status: New → Fix Committed
assignee: nobody → Alfonso Sanchez-Beato (alfonsosanchezbeato)
importance: Undecided → High
Changed in canonical-devices-system-image:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ofono - 1.12.bzr6892+15.04.20150407-0ubuntu1

---------------
ofono (1.12.bzr6892+15.04.20150407-0ubuntu1) vivid; urgency=medium

  [ Alfonso Sanchez-Beato ]
  * ubuntu-apndb.c, src/common.c, test-common.c: provision IA APNs
    LTE modems may require a new IA APN for non-GPRS operation,
    this change allows a new IA APN type to be provisioned along
    with Internet and MMS APNs.
  * gril/grilunsol.c: LTE signal strength fix (LP: #1433867)
  * ubuntu-apndb.c: load APNS w/out explict type (LP: #1437200)
  * mtkodem, plugins/mtk.c, unit/tesk-mtkunsol.c: Dynamic MTK firwmare switching
    This change causes the firmware on specific MTK-based phone to be
    dynamically switched/reset based on SIM type and roaming conditions.
  * include, plugins/mtk.c, src/modem.c, gprs.c: set data for just one slot (LP: #1413672)
    Make sure ConnectionManager.Powered property is set for only one slot in
    case the modem is of type dual SIM stand-by.
  * doc, gprs: add 'Preferred' property to GPRS contexts (LP: #1361864)
 -- CI Train Bot <email address hidden> Tue, 07 Apr 2015 06:50:28 +0000

Changed in ofono (Ubuntu):
status: Fix Committed → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.