nova lock/unlock api return code is not accurate

Bug #1449811 reported by Eli Qiao
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Confirmed
Wishlist
Unassigned

Bug Description

Currently, lock server api only returns 202(accepted) and 404(not found).
The api return code is not accurate.

The lock/unlock api in compute-api is a sync function, so the return code
of nova-api should be:

* 200 : successfully lock/unlock an instance
* 404 : instance not found
* 409 : locking/unlocking a locked/unlocked instance

Tags: api
Eli Qiao (taget-9)
Changed in nova:
assignee: nobody → Eli Qiao (taget-9)
Eli Qiao (taget-9)
Changed in nova:
status: New → Confirmed
Sean Dague (sdague)
tags: added: api
Changed in nova:
importance: Undecided → Wishlist
assignee: Eli Qiao (taget-9) → nobody
Revision history for this message
Robert Ellis (bob-ellis42) wrote :

Claiming bug. Plan on submitting fix within 2 weeks.

Changed in nova:
assignee: nobody → Robert Ellis (bob-ellis42)
Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Robert Ellis (<email address hidden>) on branch: master
Review: https://review.openstack.org/314267
Reason: It seems this is too small of a change to warrant a microversion increase.

Revision history for this message
Robert Ellis (bob-ellis42) wrote :

As stated in the review, it was requested that this change be bundled with other changes to the API as this is too small of a change to be worth doing a microversion for. Also if someone else takes this up, the return code should be a 204 as there is no body in the message.

Changed in nova:
assignee: Robert Ellis (bob-ellis42) → nobody
status: In Progress → Confirmed
stgleb (gstepanov)
Changed in nova:
assignee: nobody → stgleb (gstepanov)
status: Confirmed → In Progress
Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing
the status back to the previous state and unassigning. If
there are active reviews related to this bug, please include
links in comments.

Changed in nova:
status: In Progress → Confirmed
assignee: stgleb (gstepanov) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.