set-context-property not dual-SIM capable, uses 0-based indexing

Bug #1454751 reported by Tony Espy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
ofono (Ubuntu)
Fix Released
High
Tony Espy

Bug Description

The ofono script 'set-context-property' isn't dual-SIM capable.

The usage of the script is:

Usage: set-context-property <context> <name> <value>

The first issue is that <context> is an numeric argument and is 0-based index instead of a 1-based index like most of the other scripts.

The second issue is that it actually attempts to apply the specified property/value to each modem it finds. If both modems have a context which matches the given index, then the property will be set for each.

Finally, as there's no way to specify which modem that context belongs, so it's all or nothing.

This is being reported against the version of ofono as of vivid's release:

1.12.bzr6894+15.04.20150424.1-0ubuntu1

Related branches

Tony Espy (awe)
Changed in ofono (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Tony Espy (awe)
Tony Espy (awe)
Changed in ofono (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Tony Espy (awe) wrote :

The following pull-request fixes this bug:

https://github.com/rilmodem/ofono/pull/184

Changed in ofono (Ubuntu):
status: In Progress → Fix Committed
Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww22-2015
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ofono - 1.12.bzr6896+15.10.20150521-0ubuntu1

---------------
ofono (1.12.bzr6896+15.10.20150521-0ubuntu1) wily; urgency=medium

  [ Ratchanan Srirattanamet ]
  * build, gril, rilmodem, qcommsimmodem, plugins/qcom-msim.c: add
    support for LG L90 Dual which uses a Qualcomm dual-SIM modem (LP: #1427788)

  [ Alfonso Sanchez-Beato ]
  * src/gprs.c: support for 'ResetContexts' (LP: #1338758)
    Adds a new ConnectionManager 'ResetContexts' DBus method
    which deletes all existing gprs contexts and forces
    re-provisioning to occur.
  * plugins/ubuntu-apndb.c: ignore 'ipv6' protocol
    This change causes APNs with an 'ipv6' protocol value
    to instead be provisioned with 'ip', forcing IPv4 to
    be used.

  [ Jonas Drange ]
  * doc/connman-api.txt: add metion of 'ia' gprs context type

  [ Tony Espy ]
  * test/set-context-property: add 'Preferred' support (LP: #1454756, #1454751)
    This change adds support for the 'Preferred' ( and 'Active')
    properties which both need to be DBus variant wrapped booleans.
    Also added support for multi-SIM which was lacking from this script.
  * test/list-modems: add privacy support (LP: #1438715)
    Obfuscate any properties which can be tied to the end-user
    ( eg. SubscriberNumbers, SubscriberIdentity, ... ).

 -- CI Train Bot <email address hidden> Thu, 21 May 2015 08:44:39 +0000

Changed in ofono (Ubuntu):
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.