Mahara

Pagination in group homepages does not work properly

Bug #1457246 reported by Son Nguyen
48
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Son Nguyen
Mahara 15.10.0
15.04
Fix Released
High
Unassigned
Mahara 15.04.1
15.10
Fix Released
High
Son Nguyen
Mahara 15.10.0

Bug Description

Version: master (15.10), 15.04
Browser: any
Platform: any

The pagination of the page lists in the group homepage does now work properly when changing the sort option.

One scenario:
1. Login as a group member, create 7 pages, and share them to the group.
2. Login as the group admin, edit the group homepage, configure the "Group pages" block, change the "Sort shared pages and collections by" to "Most recently updated", and save the group homepage
3. Login as a group member, open the group homepage, navigate the list of shared pages
At first the list is sorted by "most recently updated", when click to next page or last page, the list now is sort by page title.

The bug also related to https://bugs.launchpad.net/mahara/+bug/1454458.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4789

Revision history for this message
Aaron Wells (u-aaronw) wrote :

The patch also fixes pagination for "Collections shared with this group" and "Submissions shared with this group".

So to fully test it, you need to follow the same instructions above, but for collections and submissions as well.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4789
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d692dc7dad1f13c43ab40c8114d0b514f358f79d
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit d692dc7dad1f13c43ab40c8114d0b514f358f79d
Author: Son Nguyen <email address hidden>
Date: Sat May 23 01:44:41 2015 +0000

Fix pagination in group homepage. Bug 1457246

Add editing and sortoption parameters when getting the list of group pages,
shared pages and shared collections

Change-Id: Ie1ca8ca225ac179c55629b25c4402645c959fb48

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4791

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4791
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/884a724718a1a33b1a12ec1dca9644f3bf281c04
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit 884a724718a1a33b1a12ec1dca9644f3bf281c04
Author: Son Nguyen <email address hidden>
Date: Sat May 23 01:44:41 2015 +0000

Fix pagination in group homepage. Bug 1457246

Add editing and sortoption parameters when getting the list of group pages,
shared pages and shared collections

Change-Id: Ie1ca8ca225ac179c55629b25c4402645c959fb48
(cherry picked from commit d692dc7dad1f13c43ab40c8114d0b514f358f79d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4796

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4796
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d7ce1aa7fa69dea1e0698da9e10b119644082fb9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d7ce1aa7fa69dea1e0698da9e10b119644082fb9
Author: Son Nguyen <email address hidden>
Date: Tue May 26 11:01:51 2015 +1200

Add behat test: Pagination in the "Group pages" block. Bug 1457246

Change-Id: Id5f9227be90dd350e48a5486cc82a84177f08b1d

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.