oslo.config

oslo.config/serialization unit tests broken after oslo.i18n 2.0.0 release which dropped namespace support

Bug #1469185 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.config
Fix Released
High
Doug Hellmann
oslo.config 1.13.0 "1.13.0"
oslo.serialization
Fix Released
High
Doug Hellmann
oslo.serialization 1.7.0 "1.7.0"

Bug Description

py27 runtests: commands[0] | python setup.py testr --slowest --testr-args=
running testr
running=OS_STDOUT_CAPTURE=1 OS_STDERR_CAPTURE=1 OS_TEST_TIMEOUT=60 ${PYTHON:-python} -m subunit.run discover -t ./ . --list
--- import errors ---
Failed to import test module: tests.test_generator
Traceback (most recent call last):
  File "/home/jenkins/workspace/osee-oslo-config-merge/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 445, in _find_test_path
    module = self._get_module_from_name(name)
  File "/home/jenkins/workspace/osee-oslo-config-merge/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 384, in _get_module_from_name
    __import__(name)
  File "tests/test_generator.py", line 26, in <module>
    from oslo.i18n import fixture as i18n_fixture
ImportError: No module named i18n

This was the change in oslo.i18n: https://review.openstack.org/#/c/181971/

Revision history for this message
Matt Riedemann (mriedem) wrote :

You can see the oslo.config code hasn't been updated:

https://github.com/openstack/oslo.config/blob/master/tests/test_generator.py#L26

Changed in oslo.config:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Matt Riedemann (mriedem)
assignee: Matt Riedemann (mriedem) → Doug Hellmann (doug-hellmann)
status: Triaged → In Progress
Revision history for this message
Matt Riedemann (mriedem) wrote :

Should be fixed with this: https://review.openstack.org/#/c/181961/

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :

Need this to merge https://review.openstack.org/#/c/181980/ for oslo.serialization

summary: - oslo.config unit tests broken after oslo.i18n 2.0.0 release which
- dropped namespace support
+ oslo.config/serialization unit tests broken after oslo.i18n 2.0.0
+ release which dropped namespace support
Revision history for this message
Matt Riedemann (mriedem) wrote :

Here is a g-r block on oslo.i18n 2.0.0:

https://review.openstack.org/#/c/196072/

I think that should get into an oslo.config 1.12.2 release before namespace support is dropped for oslo.config which will result in a 2.0.0 version.

OpenStack Infra (hudson-openstack)
Changed in oslo.config:
assignee: Doug Hellmann (doug-hellmann) → Davanum Srinivas (DIMS) (dims-v)
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

https://review.openstack.org/196147 fixes the problem in oslo.serialization and https://review.openstack.org/196151 fixes it for oslo.config.

Changed in oslo.config:
assignee: Davanum Srinivas (DIMS) (dims-v) → Doug Hellmann (doug-hellmann)
Changed in oslo.serialization:
assignee: nobody → Doug Hellmann (doug-hellmann)
status: New → In Progress
Changed in oslo.config:
status: In Progress → Fix Committed
Changed in oslo.serialization:
importance: Undecided → High
Davanum Srinivas (DIMS) (dims-v)
Changed in oslo.config:
milestone: none → 1.13.0
status: Fix Committed → Fix Released
Davanum Srinivas (DIMS) (dims-v)
Changed in oslo.serialization:
status: In Progress → Fix Committed
Davanum Srinivas (DIMS) (dims-v)
Changed in oslo.serialization:
milestone: none → 1.7.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.