Mahara

Make View::view_search() supported combined listing of pages & collections

Bug #1476496 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Aaron Wells
Mahara 15.10.0

Bug Description

To support Bug 1476491, Bug 1476492, and Bug 1476495, we need to make View::view_search() return a combined list of views & collections, as if they were equivalent entities.

To achieve this, I plan to add YET ANOTHER argument to View::view_search().

In the longer run, we should probably put some serious thought into refactoring this method.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4997

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4997
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/c2a427e209d67f2cc15024d84680a73b89d7382c
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit c2a427e209d67f2cc15024d84680a73b89d7382c
Author: Aaron Wells <email address hidden>
Date: Mon Jul 13 16:17:35 2015 +1200

Support for collections & views in View::view_search()

Bug 1476496: Adds a new argument that makes View::view_search()
return a combined list of collections & "solo views" that don't
belong to any collection.

behatnotneeded: Covered by existing tests

Change-Id: Iceba8f9606fc1c537880ad8c3eabadd1e9f7da8c

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The feature for which this API is needed was sponsored by Pratt Institute in Brooklyn, NY. Thank you very much.

tags: added: nominatedfeature
Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/15.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.