Mahara

Bootstrap tabs are not accessible

Bug #1482458 reported by Jono M
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jono M
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

The new Bootstrap theme means that tabs (eg. on the Profile page) are rather different to previous versions of Mahara. In theory the included bootstrap-accessibility library should take care of adding ARIA features to them, but unfortunately it seems to be overcomplicating matters to the point of confusion. There are various issues with the JAWS screen reader, which may or may not be related to this library ... need to investigate why these issues are happening.

1. Tabs can't be changed without going into "forms" mode (pressing Enter with a tab selected does nothing)
2. All tabs are described as "tab selected"
3. When selecting a tab with the keyboard (without a screen reader), tabindex attributes are added to the tab and its content, messing up the tab order of the page

Affects latest master

Jono M (jonom)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Jono Mingard (mingard)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5095

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5153

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5153
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/d2d8b8e356904c437e910f0b2c26d9f6659ea5ae
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d2d8b8e356904c437e910f0b2c26d9f6659ea5ae
Author: Jono Mingard <email address hidden>
Date: Thu Aug 20 13:42:43 2015 +1200

Use non-minified version of bootstrap-accessibility

Fixing bug #1482458 requires modifying the library, so the full JS
file needs to be included instead of the minified version.

behatnotneeded

Change-Id: Iededf7ce7cbc5abff8cede2e1c2e04f28ca1a7b0

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5357

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5095
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4177ba9cbcea887f82afe520256a1d2e4cabbbf0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4177ba9cbcea887f82afe520256a1d2e4cabbbf0
Author: Jono Mingard <email address hidden>
Date: Thu Aug 13 17:08:06 2015 +1200

Fix ARIA roles on bootstrap tabs (Bug #1482458)

Add tablist and tabpanel roles, and ensure that tabs are linked to
their containers with aria-controls.
Normalizes behaviour across various screen readers, ensuring that
they report click events etc.

behatnotneeded

Change-Id: I51ee2a09a67609be6f917f8894d4e4852a7d6101
Signed-off-by: Jono Mingard <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Jono M (jonom) wrote :

Hi,

I wasn't able to fix this bug entirely, so the user manual should probably be updated to specify how screen reader users can use the tabs. The tabs don't work if you focus them using the arrow keys, so you need to focus them using the Tab key in order to switch tabs.

tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.