"find in page" should be disabled while the new tab view is visible
Bug #1483847 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Ugo Riboni | ||
Bug Description
The "find in page" feature just landed (in webbrowser-app 0.23+15.
There’s one minor issue with it: the UI allows the user to switch to "find in page" mode while in the new tab view, but obviously this doesn’t search the view, so it is useless and confusing. The option should be disabled while in the new tab view.
Steps to reproduce:
1) Launch the browser
2) Open a new tab
3) Open the drawer menu
Expected: there is no "find in page" entry
Current: there is a "find in page" entry
4) [if on desktop] Press Ctrl+F
Expected: nothing happens
Current: the browser switches to "find in page" mode
Related branches
lp:~uriboni/webbrowser-app/no-find-in-page-in-new-tab
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 82 lines (+25/-3)3 files modifiedsrc/app/webbrowser/Browser.qml (+4/-3)
tests/autopilot/webbrowser_app/tests/test_findinpage.py (+17/-0)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+4/-0)
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Ugo Riboni (uriboni) |
| importance: | Undecided → Medium |
| importance: | Medium → High |
| status: | New → Triaged |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+15.
---------------
webbrowser-app (0.23+15.
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Ugo Riboni ]
* Delay the exit from fullscreen mode until focus remains lost for a
certain amount of time. (LP: #1477308)
* Disable find in page when the new tab view is active. (LP: #1483847)
-- CI Train Bot <email address hidden> Fri, 14 Aug 2015 09:25:42 +0000