hostspot "show password" uses a switch instead of a checkbox
Bug #1484703 reported by
Sebastien Bacher
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-system-settings (Ubuntu) |
Fix Released
|
Low
|
Jonas G. Drange | ||
Bug Description
The design has a checkbox, also mpt explained once that switch are for objects and checkbox should be used for actions/verbs, in this case the label is "show password" so it should be a checkbox
Related branches
lp:~jonas-drange/ubuntu-system-settings/allow-insecure-hotspot
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ken VanDine: Approve
- Matthew Paul Thomas (community): Needs Fixing
- Pete Woods: Pending requested
-
Diff: 846 lines (+421/-106)14 files modifieddebian/control (+2/-2)
plugins/hotspot/CMakeLists.txt (+2/-0)
plugins/hotspot/HotspotSetup.qml (+95/-42)
plugins/hotspot/PageComponent.qml (+3/-10)
plugins/hotspot/hotspot.settings (+2/-1)
plugins/hotspot/plugin/CMakeLists.txt (+8/-0)
plugins/hotspot/plugin/hotspot-plugin.cpp (+88/-0)
plugins/hotspot/plugin/hotspot-plugin.h (+39/-0)
tests/autopilot/ubuntu_system_settings/__init__.py (+15/-0)
tests/autopilot/ubuntu_system_settings/tests/__init__.py (+70/-41)
tests/autopilot/ubuntu_system_settings/tests/connectivity.py (+12/-0)
tests/autopilot/ubuntu_system_settings/tests/systemimage.py (+48/-0)
tests/autopilot/ubuntu_system_settings/tests/test_hotspot.py (+22/-9)
tests/autopilot/ubuntu_system_settings/tests/test_plugins.py (+15/-1)
Revision history for this message
| Sebastien Bacher (seb128) wrote | #1 |
Revision history for this message
| Sebastien Bacher (seb128) wrote | #2 |
| Changed in ubuntu-system-settings (Ubuntu): | |
| assignee: | nobody → Jonas G. Drange (jonas-drange) |
| importance: | Undecided → Low |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | New → Fix Committed |
| Changed in ubuntu-system-settings (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
there are also some label issues, "Setup" vs "Set Up", "Key" vs "Password", there is also too much spacing between the separator and the caption