Call to deluge.core.Torrent.set_trackers() fails when trackers parameter is None

Bug #1487704 reported by Carlos Maddela
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
deluge (Ubuntu)
Fix Released
Low
Unassigned
Vivid
Won't Fix
Low
Unassigned
Wily
Fix Released
Low
Unassigned
Xenial
Fix Released
Low
Unassigned

Bug Description

DistroRelease: Ubuntu 15.04
Package: deluge-common 1.3.11-0ubuntu2
Architecture: amd64

I was trying to write my own plugin, which made a call to deluge.core.Torrent.set_trackers() with the 'trackers' parameter set to None. From the source code, you can see that what's supposed to happen is the current list of trackers is refreshed, however because the distro release uses a more recent version of libtorrent, the function call fails with an "AttributeError: 'dict' object has no attribute 'url'" exception.

This is related to the upstream bug #2223: http://dev.deluge-torrent.org/ticket/2223. It was fixed in the Torrent constructor, but not in set_trackers().

I have made a patch which fixes this bug. I have tried logging this bug upstream as well, but I've had no luck in creating an account at the above site. Should you accept my patch, can you please forward it upstream also?

Thanks.

Related branches

Revision history for this message
Carlos Maddela (e7appew) wrote :
Revision history for this message
Cas (calumlind) wrote :

Thanks but for several reasons it's simpler to just add the same if..else in set_trackers. Fixed in 1.3-stable: http://git.deluge-torrent.org/deluge/commit/?h=1.3-stable&id=acf4fc4193d

For reference about Deluge Trac registering bug: http://forum.deluge-torrent.org/viewtopic.php?f=8&t=51737&p=213071#p213071

Changed in deluge (Ubuntu):
status: New → Fix Committed
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Since upstream fixed this differently. Could you please prepare a new merge request with the same fix as upstream? Thanks!

Changed in deluge (Ubuntu):
status: Fix Committed → Confirmed
Revision history for this message
Cas (calumlind) wrote :

Why patch when there is a new 1.3.12 release?

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

@cas I'll get it into Debian and synced to Ubuntu +1 sometime before EOW.

Revision history for this message
Carlos Maddela (e7appew) wrote :

If you would still like vivid to have the cherry-picked upstream fix, without introducing other changes in the new 1.3.12 release, I have uploaded the changes to lp:~e7appew/ubuntu/vivid/deluge/fix-set-trackers-cherry-picked.

Cas (calumlind)
Changed in deluge (Ubuntu):
status: Confirmed → Fix Released
Mathew Hodson (mhodson)
Changed in deluge (Ubuntu):
importance: Undecided → Low
Revision history for this message
Cas (calumlind) wrote :

Deluge PPA has 1.3.12 available for vivid: https://launchpad.net/~deluge-team/+archive/ubuntu/ppa

Changed in deluge (Ubuntu Wily):
status: New → Fix Released
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good, ack. Uploaded for processing by the SRU team. Thanks!

Changed in deluge (Ubuntu Vivid):
status: New → In Progress
Revision history for this message
Cas (calumlind) wrote :

I am a bit perplexed as to why this issue and patch is getting so much attention when has no bearing on end users. The entire 1.3.12 release has many more important fixes that directly affect users so if anything that should be where effort is concentrated for Vivid and even Trusty.

Revision history for this message
Cas (calumlind) wrote :

I should also add that if the OP is creating a plugin then it needs to be able to handle and workaround this bug otherwise it will break with all Deluge versions below 1.3.12 on other platforms so patching 1.3.11 in Vivid is not a good solution. Also of note Vivid is EOL in January 2016.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Carlos, or anyone else affected,

Accepted deluge into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/deluge/1.3.11-0ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in deluge (Ubuntu Vivid):
status: In Progress → Fix Committed
tags: added: verification-needed
Mathew Hodson (mhodson)
Changed in deluge (Ubuntu Vivid):
importance: Undecided → Low
Changed in deluge (Ubuntu Wily):
importance: Undecided → Low
tags: added: vivid
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote : [deluge/vivid] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for vivid for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Mathew Hodson (mhodson)
Changed in deluge (Ubuntu Vivid):
status: Fix Committed → Won't Fix
Revision history for this message
Martin Pitt (pitti) wrote : Proposed package removed from archive

The version of deluge in the proposed pocket of Vivid that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.

tags: removed: verification-needed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.