First cut of source packages for -mobile promotions

hildon-fm-l10n review:
 - uses nonstandard gettext (abstract identifiers as C string instead of the English version), so it won't work with our usual stripping and Rosetta import/export
 - should not be a native package
 - please fix the weird version number

maemo-af-desktop-l10n review:
 - uses nonstandard gettext (abstract identifiers as C string instead of the English version), so it won't work with our usual stripping and Rosetta import/export
 - building separate packages maemo-af-desktop-l10n-{english, engb} is confusing and weird. If there should really be one package per locale, then please use en-us and en-gb, but preferably the translations would be built by langpack-o-matic automatically (language-pack-mobile-<locale>).
 - should not be a native package
 - please fix the weird version number

libfakekey looks good, ready for promotion.

libosso review:
 - should not be a native package
 - libosso-test is empty
 - libosso-dev ships the same html files as -doc, they should be removed
 - What is the motivation for the separate libosso-dbus-conf package? the description does not say much about the purpose, and none of the binaries ship any dbus service.
 - the system bus policy currently says "allow all operations for all users on all backends", which is not acceptable for a package in main (since this opens a huge security hole if someone installs this on an Ubuntu desktop system).
 - The session bus policy has the same problem, it allows all users to connect to all other user's session buses. That might not be a problem on mobile devices, but if they get multiuser support, or run some privilege separation (e. g. between browser and local apps), then this should be restricted sensibly, too.

libhildonfm looks fine except for being a native package. Once that's sorted out, it is ready for promotion.

General petition: I don't see the point in shipping the entire .bzr tree in the source package. It makes the orig.tar.gz files much bigger than they need to be, and the branches are on LP anyway. debian/control should have Vcs-Bzr: headers, so that getting the bzr branches can be done with our existing tools (bzr-buildpackage, apt-get source, etc.)

libhildonmime looks fine except for being a native package. Once that's sorted out, it is ready for promotion.

libhildon:

 - uses nonstandard gettext (abstract identifiers as C string instead of the English version), so it won't work with our usual stripping and Rosetta import/export
 - includes .bzr directory
 - should not be a native package

libhildonhelp:

- should not be a native package

libmatchbox looks ready for promotion.

tasks:

 - the package name is a bit unspecific, but is just taken from debian.
 - debian/copyright should list the copyright holder ( Copyright (C) 2007 OpenedHand Ltd )

looks ready for promotion.besides the copyright notice

general note: please include the copyright/license for the packaging as well (as long as these packages do not come from debian) and are otherwise unmodified.

mce-dev: looks ready for promotion

matchbox-keyboard:

 - many single files do not include a license and copyright notice; if we do assume, that the COPYING file (GPLv2) is the license for these files, the copyright holder is still missing from these files.
 - otherwise looks ok for promotion

Unsure if that hinders us from promoting the package to main.

matchbox-window-manager:

 - looks ok for promotion to main

osso-af-settings:

 - overkill packaging for just one file

but looks ok for promotion to main.

osso-gwconnect:

 - should not be a native package
 - includes .bzr directory
 - init scripts in main should not use `echo', please use the lsb functions instead.

hildon-desktop:

 - should not be a native package
 - uses nonstandard gettext (abstract identifiers as C string instead of the English version), so it won't work with our usual stripping and Rosetta import/export (there are some strings in src, but without a pot file)

haf-marketing-release:

 - No license listed, just a copyright holder.
 - otherwise ok for promotion to main (just a dependency package).

cheese:

 - looks read for promotion.

Mobile team, please tell me whether I should promote the good packages now, or wait until the entire stack is ready for promotion.

Please promote whichever packages are in good shape, and don't have any dependencies at your convenience.

According to Tollef; Ubuntu has been just fine with missing copyright headers as long as the tarball as such has a licence of sorts.

Further more, please promote cheese, osso-af-settings, matchbox-window-manager, matchbox-keyboard, mce-dev, libmatchbox and libfakekey; presuming the above is enough to have matchbox-keyboard promoted.

cheese promotion is blocked by libhildon.

I promoted the other ones now (osso-af-settings matchbox-window-manager libmatchbox matchbox-keyboard mce-dev libfakekey).

tasks promoted.

I have uploaded repacks of libhildon, libhildonfm, libhildonhelp, libhildonmime, and osso-gwconnect.

libhildonfm approved

libhildonhelp approved. Promotion blocked on promotion of libhildon (same as for libhildonfm).

libhildonmime promoted

osso-gwconnect approved. Promotion blocked by promotion of libosso.

libhildon approved, since it does not seem to use/install l10n yet anyway. Promotion will entirely break the current nonstandard l10n, so depending on whether l10n or having it in main is more important I can do either.

Matthias already approved cheese, but promotion is blocked by promotion of libhildon.

Needs libhildon promotion question answered.

At this point, having it in main is more important. The l10n issue will be addressed in due course.

Promoted: libhildon libhildonfm libhildonhelp cheese

Tasks was promoted but it Build-Depends on libosso-dev which hasn't been promoted.

Sorry, that slipped past my checks. I demoted tasks again for the time being, until libosso is ready for promotion.

I've uploaded hildon-desktop, hildon-fm-l10n and maemo-af-desktop-l10n today, if you could check them again, please.

I've uploaded a new upstream release of tasks, which doesn't need libosso-dev, so it should be ok to promote it again.

Tasks re-promoted to main, thanks Emilio!

hildon-fm-l10n promoted to main, since this appears to be important.

Please keep in mind that the next time you'll upload this, the package will be ABSOLUTELY USELESS and empty, due to the inadequate i18n in hildon.

hildon-desktop promoted to main, with the usual "broken i18n" stamp.

maemo-af-desktop-l10n review of the latest version:
 - uses nonstandard gettext (abstract identifiers as C string instead of the English version), so it won't work with our usual stripping and Rosetta import/export, and the .debs will be completely empty and thus useless.
 - building separate packages maemo-af-desktop-l10n-{english, engb} is confusing and weird. If there should really be one package per locale, then please use en-us and en-gb, but preferably the translations would be built by langpack-o-matic automatically (language-pack-mobile-<locale>).

libosso has been uploaded

libosso review, take 2. Thanks for fixing most of the issues. However, the system dbus policy is still a single huge security trojan horse. Please rewrite it completely in a restrictive manner, precisely define which user can own the osso dbus service and who can connect to it (and which restrictions apply to privileged functions). Please take a look at the numerous examples in /etc/dbus/system.d/.

Thank you! Martin

I have uploaded a new version of libosso. Please ignore the sessionbus file, which isn't patched, because it isn't installed.

libosso> The current dbus policy still allows anyone to own the osso service on the system bus. Ideally this thing would exclusively use the user's session bus, since it already seems to be per-user (i. e. there is no system daemon which provides that service, it's only a client side library). With that, an user cannot hijack the osso service of another user, and you could actually run two parallel users sessions.

libosso uploaded, now with a patch that sets the system bus connection to the session bus connection. It's a little nasty, but involves the least amount of code changes, and everything works without the two evil dbus configuration files.

libosso promoted. Thanks for fixing it!

osso-gwconnect promoted.

haf-marketing-release dealt with by way of getting it removed and having other packages provide the bits it does.

New hildon-fm-l10n and maemo-af-desktop-l10n uploaded -- both with NO_PKG_MANGLE. Yes, it is strange that maemo-af-desktop-l10n builds two seperate english packages, they are both en_US, and contain different strings -- it is going to take some time to nail it down with upstream.

hildon-thumbnail also needs to be reviewed for a promotion to main -- it is used by some libhildon things, and a few things like hildon-desktop Build-Depend on it. I have uploaded a new upstream version earlier today.

maemo-af-desktop-l10n promoted, with gnashing my teeth. :)

hildon-thumbnail looks good, promoted.