Use of "next" instead of "continue" in bash script failsafeXServer

Bug #149304 reported by Mikael Nilsson
2
Affects Status Importance Assigned to Milestone
xorg (Ubuntu)
Fix Released
Low
Bryce Harrington

Bug Description

Binary package hint: x11-common

The script /etc/gdm/failsafeXServer managed to not work for at one occasion, due to the use of the "next" command instead of "continue" - next is not recognized by bash.

 Most times the script does work because it does not hit that path, though.

Try the following to verify

for i in 1 2 3 4 5; do
  if [ $i = 3 ]; then
    echo got it $i
    next
  fi
  echo $i
done

result:
1
2
got it 3
/bin/bash: next: command not found
3
4
5

which is the same error message I found at the time in .xsession-errors

Related branches

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, good catch. Looks like a minor error, but incorrect nonetheless. I'll commit this in the next xorg upload.

Changed in xorg:
assignee: nobody → bryceharrington
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Bryce Harrington (bryce) wrote :

xorg (1:7.2-5ubuntu13) gutsy; urgency=low

  * debian/local/Failsafe/failsafeXServer:
    + Change next to continue (closes LP: #149304)
  * debian/local/Failsafe/failsafeXinit:
    + Fix typo s/XORGCONF/XORGCONFIG/

 -- Bryce Harrington <email address hidden> Sun, 07 Oct 2007 09:56:15 -0700

Changed in xorg:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.