Mahara

Web services auth uses wrong lang string in auth list

Bug #1494565 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 15.10.0
15.04
Fix Released
Medium
Unassigned
Mahara 15.04.4
15.10
Fix Released
Undecided
Unassigned

Bug Description

Mahara 15.04 and 15.10

When you are on /admin/users/institutions.php and edit an institution, you an choose "Web services" from the list of authentication methods. The description only reads "Description" instead of the actual description "Web services-only users authenticated against Mahara's database".

I tracked it down to the following (in Mahara 15.10):
The "description" string on line 16 of /auth/webservice/lang/en.utf8/auth.webservice.php is correct. However, the auth list uses string "description" from line 153 from the section "wsdoc" instead.

When I comment the wsdoc "description" out, the proper description shows up in the authlist. So changing the string ID for the wsdoc to "wsdocdescription" should all that is needed. Unfortunately, I couldn't identify where I could change the string in the code and thus couldn't change it myself.

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
no longer affects: mahara/1.10
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5267

Revision history for this message
Robert Lyon (robertl-9) wrote :

The 2nd 'description' text is used here -

Go to Administration -> Extensions ->Webservices

Expand the 'Manage service groups' expander

Click on any of the links in the 'Functions' column

And you will be taken to a page explaining the function

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5267
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/a02ae2c709ffa6f83b3987d06025478688e9643d
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit a02ae2c709ffa6f83b3987d06025478688e9643d
Author: Robert Lyon <email address hidden>
Date: Fri Sep 11 16:16:48 2015 +1200

Bug 1494565: sorting out problem with 2 'description' fields

Renaming the 2nd one

behatnotneeded

Change-Id: Ib39b868db92a60b1640fdd28603ca513148b6d23
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5428

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5428
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/37b4b433c9838e7567ea31d1fbb2ca8247404389
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 37b4b433c9838e7567ea31d1fbb2ca8247404389
Author: Robert Lyon <email address hidden>
Date: Fri Sep 11 16:16:48 2015 +1200

Bug 1494565: sorting out problem with 2 'description' fields

Renaming the 2nd one

behatnotneeded

Change-Id: Ib39b868db92a60b1640fdd28603ca513148b6d23
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.