Webservice create_users() has old social profile fields

Bug #1507865 reported by Ghada El-Zoghbi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

The following fields are still implemented in the Webservice create_users:

- aimscreenname
- icqnumber
- msnnumber
- yahoochat
- skypusername
- jabberusername

Which were all replaced by the new blocktype 'social profile' in the internal artefact.

If someone were to create a user and specify one of these fields, the set_profile_field() will raise an error when generating the class name (generate_artefact_class_name()) for the field.

I haven't actually tried to use the webservice but can see that it will cause an error.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5570

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 16.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5682

Revision history for this message
Robert Lyon (robertl-9) wrote :

To test webservices:

1) Go to Admin -> Extenstions -> Webservices test client and make sure web services is switched on

2) Go to Institutions and create an institution

3) Edit institution and for the 'Authentication plugin' dropdown pick 'Webservices ...' and click 'Add' button then hit submit at bottom of form

4) Go to Admin -> Users and click on a username of a user add them to the new institution (bottom of form)

5) Now change their 'Authentication method' field to the one that is the institution name + 'webservice' - click the 'save changes' button

6) Go back to Admin -> Extenstions -> Webservices and expand the 'Manage service access tokens' part and search for the user and click 'Generate token'

7) On the next form click the 'Back' link at base of form - as we don't need to change anything thereat the moment

8) You should see the user now listed with a 'Token' set - copy this token somewhere as you need it

9) Go to the 'Web service test client' page.
- For protocol choose any of the options
- For Type leave on 'Token'
go 'Next'
- Choose User Provisioning
go 'Next'
- Choose 'mahara_user_create_users'
go 'Next'
Try creating a user by filling in details into the fields
I think the first 5 fields are compulsory - but try finning different combinations of other options

The check that the users were created by logging in as them

Have fun!

Revision history for this message
Charlie Amoah (charlie-catalyst) wrote :

Error message when trying to add a user via web services

Revision history for this message
Charlie Amoah (charlie-catalyst) wrote :

Hi Robert I am still not having any luck with this. After setting up the authentication for the webservices when i tried creating a new user I got an error after saving it. Please see the attached screen shot.

Revision history for this message
Charlie Amoah (charlie-catalyst) wrote :

Hi Robert I am still having issues with this bug. After testing: https://reviews.mahara.org/#/c/5570/ with the instructions on the bug, I proceeded to test: https://reviews.mahara.org/#/c/5682/8.

After I had authenticated the web services I proceeded to create a user to ensure the clean up fot the page had been implemented. I got shown an error upon saving the user.

Please see the attached screen shot.

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/6113

Changed in mahara:
milestone: 16.04.0 → 16.10.0
Revision history for this message
Charlie Amoah (charlie-catalyst) wrote :

Hi team am still not having any luck with this bug. I get an error when I try creating a new user after configuring the web service test client. Unless I am doing something wrong Please see the screen shot.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

It works as expected, but there was a step missing in the instructions. When the user is assigned the web services auth, they also need to be an admin when the option "mahara_user_create_users" is supposed to be used because if their user permissions don't allow them to create users, an error would come up. :-)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5682
Committed: https://git.mahara.org/mahara/mahara/commit/09e8fc4dd8e0f86d7d690149cc8bdbad01776da4
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 09e8fc4dd8e0f86d7d690149cc8bdbad01776da4
Author: Robert Lyon <email address hidden>
Date: Fri Oct 30 13:41:44 2015 +1300

Bug 1507865: Some webservices clean up of test client area

1) Have select boxes for some fields that contain fixed set of data,
eg country, institution.

2) Have switches for boolean fields

3) Have the description information recorded to actually show up with
the fields

4) Make the password field be pieform type 'password'

behatnotneeded: unable to function when not under https

Change-Id: Icc0b5be13683acf7b1fff8479f8bb65766576ce6
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5570
Committed: https://git.mahara.org/mahara/mahara/commit/4bc12f6abbc832fbcd9766518796ae4a45351034
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 4bc12f6abbc832fbcd9766518796ae4a45351034
Author: Robert Lyon <email address hidden>
Date: Tue Apr 5 15:45:18 2016 +1200

Bug 1507865: removing the old social profile options from webservices

behatnotneeded: Unable to test without https

It cant reach the webservices/functions/mahara_user_external.php page

Change-Id: I7196bbd6a9963b3003e4915a3a4faeeab609e212
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.