Crash when posting a public comment that no one will be notified about
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Aaron Wells | ||
15.10 |
Fix Released
|
High
|
Aaron Wells | ||
16.04 |
Fix Released
|
High
|
Aaron Wells | ||
16.10 |
Fix Released
|
High
|
Unassigned |
Bug Description
The code that sends out comment notifications tries to merge two arrays, representing the users who need to be notified because they "own" the page, and the users who have the page on their watchlist. If there are no "owner" users for a page, then this code fails because that variable holds a boolean false instead of an array.
This only happens for public comments, because for private comments the watchlist is ignored, so there's no need to try to merge the arrays.
To replicate:
1. Create a group
2. In the group's settings set "Feedback notifications" to "None"
3. Create a page in the group
4. Leave a public comment on the page
Expected result: Your public comment should be posted on the page
Actual result: The AJAX "processing" message comes up but never finishes, and the comment doesn't post
Changed in mahara: | |
status: | Fix Committed → Fix Released |
This was a regression introduced during the code changes for threaded feedback (Bug 884023).