Augeas 1.3 can't read some conf files

Bug #1510318 reported by Noah Swartz
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
augeas (Ubuntu)
Fix Released
High
Unassigned
Vivid
Won't Fix
Low
Unassigned
Wily
Won't Fix
Low
Unassigned

Bug Description

https://github.com/hercules-team/augeas/issues/191
Augaes 1.3 can't read certain ssl.conf files, such as one of the ones Let's Encrypt uses: https://github.com/letsencrypt/letsencrypt/issues/981
versions 1.2 and 1.4 of augaes don't have this problem, but currently vivid and wily are distributing version 1.3: http://packages.ubuntu.com/search?keywords=augeas-lenses
For Let's Encrypt to work for all Ubuntu users this bug should be fixed for them.

Tags: bitesize patch
Revision history for this message
Robie Basak (racb) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better.

We can't bump augeas in Vivid and Wily as they are already released, but it looks like it should be fairly easy to cherry-pick just this fix without regressing existing users. Is this accurate?

In this case, if somebody can prepare and test a backported patch for 1.3.0-0ubuntu1, I will be happy to help drive this to a fix in Wily, Vivid and Xenial which all currently are on that version.

I will need a commitment from someone to verify the fix for each release as even though I appreciate there is an automated test case, we do still require manual verification for updates to stable releases in order to minimise risk of regression to existing users.

If you're interested in the process, it is documented at https://wiki.ubuntu.com/StableReleaseUpdates

Revision history for this message
Robie Basak (racb) wrote :

Importance: High because I think it's important to the Ubuntu Server Team to help ensure that Let's Encrypt works well on Ubuntu. Find me (rbasak) in #ubuntu-server on Freenode during UK working hours if you need any help.

Changed in augeas (Ubuntu):
importance: Undecided → High
tags: added: bitesize
Revision history for this message
Dominic Cleal (domcleal) wrote :

I'm attaching the trio of commits to fix the bug in a single patch, rebased on top of the upstream 1.3.0 release. Hopefully somebody can use this as the basis of a patch against the package itself.

Locally it seems to resolve parsing of the ssl.conf file at https://github.com/letsencrypt/letsencrypt/issues/981#issuecomment-148485384.

Revision history for this message
Dominic Cleal (domcleal) wrote :

With regards to manual regression testing for a stable update, I'd suggest running "augtool print /files/etc/apache2" (with Apache, mod_ssl and optionally, other Apache modules installed) to check if any files that used to parse now fail in any way. Hopefully the number of errors will be reduced.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Patch against upstream release-1.3.0" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Robie Basak (racb)
Changed in augeas (Ubuntu):
status: New → Triaged
Changed in augeas (Ubuntu Vivid):
status: New → Triaged
Changed in augeas (Ubuntu Wily):
status: New → Triaged
Changed in augeas (Ubuntu Vivid):
importance: Undecided → High
Changed in augeas (Ubuntu Wily):
importance: Undecided → High
Revision history for this message
Robie Basak (racb) wrote :

Thanks Dominic. I've uploaded this to Xenial, which as it is for the development release I don't have to worry as much about regressing existing users.

Can someone confirm that the problem with letsencrypt is fixed with Xenial, please (or just manually grab the .deb files from Xenial and install it on Wily if you like - that should work)? As I'm just blindly cherry-picking patches here, I'd prefer if someone affected could confirm, and then I'll upload SRUs for Vivid and Wily.

Changed in augeas (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package augeas - 1.3.0-0ubuntu2

---------------
augeas (1.3.0-0ubuntu2) xenial; urgency=medium

  * Fix parsing of Apache httpd ssl.conf files by cherry-picking three
    commits from upstream (LP: #1510318):
    - d/p/Httpd-Do-not-pass-empty-as-body-to-section.patch
    - d/p/Httpd-Make-illegal-in-char_arg_dir.patch
    - d/p/Httpd-Properly-manage-eol-after-opening-tag.patch

 -- Robie Basak <email address hidden> Tue, 27 Oct 2015 12:26:38 +0000

Changed in augeas (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote :

> or just manually grab the .deb files from Xenial and install it on Wily if you like - that should work

I should add that if you do this you should manually downgrade back to packages from Wily later, to make sure that you receive any future security updates.

Revision history for this message
Robie Basak (racb) wrote :

Looks like upstream no longer needs this since they have embedded the lens they need, so no point backporting this fix to stable releases. It is fixed in the development release for the future.

Changed in augeas (Ubuntu Vivid):
importance: High → Low
Changed in augeas (Ubuntu Wily):
importance: High → Low
Changed in augeas (Ubuntu Vivid):
status: Triaged → Won't Fix
Changed in augeas (Ubuntu Wily):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.