Mahara

Missing langstring "mobileuploadnotenabled" in MaharaDroid API

Bug #1512542 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned
Mahara 16.04.0
1.10
Fix Released
Low
Unassigned
Mahara 1.10.8
15.04
Fix Released
Low
Unassigned
Mahara 15.04.5
15.10
Fix Released
Low
Unassigned
Mahara 15.10.1

Bug Description

While trying to connect MaharaDroid to a 15.10.0 site that had the mobile uploads option turned off at the site level, I got back an error response that had a missing lang string identifier in it: [[mobileuploadnotenabled/account]]

Aaron Wells (u-aaronw)
tags: added: api behat-not-needed maharadroid mobileuploads
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5652

Revision history for this message
Aaron Wells (u-aaronw) wrote :

This bug's been present since the beginning. The "mobileuploadnotenabled" string was defined in lang/auth.php, but the call to get_string() looked for in lang/account.php, so that explains the error.

I'm changing the call to get_string() to look in auth.php, since it'll already be translated there, and it nicely groups together all the mobileupload error strings in one file.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

It's a low-priority bug, but it's a trivial fix so we may as well backport it to all supported versions.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5652
Committed: https://git.mahara.org/mahara/mahara/commit/31256ffb94b6cdacf3330804bfc45bca2f737386
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 31256ffb94b6cdacf3330804bfc45bca2f737386
Author: Aaron Wells <email address hidden>
Date: Tue Nov 3 13:53:49 2015 +1300

Missing lang string used by MaharaDroid API (Bug 1512542)

behatnotneeded: Can't test mobileupload API in Behat

Change-Id: Ied63c973fc125d4f2d403dcdd75be28c0314aeec

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5750

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5750
Committed: https://git.mahara.org/mahara/mahara/commit/165036dad0cabaa687e989b7cdb648aba1647647
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 165036dad0cabaa687e989b7cdb648aba1647647
Author: Aaron Wells <email address hidden>
Date: Tue Nov 3 13:53:49 2015 +1300

Missing lang string used by MaharaDroid API (Bug 1512542)

behatnotneeded: Can't test mobileupload API in Behat

Change-Id: Ied63c973fc125d4f2d403dcdd75be28c0314aeec
(cherry picked from commit 31256ffb94b6cdacf3330804bfc45bca2f737386)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5751

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5751
Committed: https://git.mahara.org/mahara/mahara/commit/f4439b7a813141587296656b1a4b856925ea41c4
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit f4439b7a813141587296656b1a4b856925ea41c4
Author: Aaron Wells <email address hidden>
Date: Tue Nov 3 13:53:49 2015 +1300

Missing lang string used by MaharaDroid API (Bug 1512542)

behatnotneeded: Can't test mobileupload API in Behat

Change-Id: Ied63c973fc125d4f2d403dcdd75be28c0314aeec
(cherry picked from commit 31256ffb94b6cdacf3330804bfc45bca2f737386)
(cherry picked from commit 165036dad0cabaa687e989b7cdb648aba1647647)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5752

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5752
Committed: https://git.mahara.org/mahara/mahara/commit/609ca1af62cadae88c2841895553a628f40bc6ac
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 609ca1af62cadae88c2841895553a628f40bc6ac
Author: Aaron Wells <email address hidden>
Date: Tue Nov 3 13:53:49 2015 +1300

Missing lang string used by MaharaDroid API (Bug 1512542)

behatnotneeded: Can't test mobileupload API in Behat

Change-Id: Ied63c973fc125d4f2d403dcdd75be28c0314aeec
(cherry picked from commit 31256ffb94b6cdacf3330804bfc45bca2f737386)
(cherry picked from commit 165036dad0cabaa687e989b7cdb648aba1647647)
(cherry picked from commit f4439b7a813141587296656b1a4b856925ea41c4)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.