Mahara

Export portfolio as html gives an "error" due to missing views.css file

Bug #1515826 reported by Ghada El-Zoghbi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 16.04.0
15.10
Fix Released
High
Unassigned
Mahara 15.10.1

Bug Description

$config->version = 2015092910;
$config->series = '15.10';
$config->release = '15.10.0';

DB: Postgres
OS: Linux

When exporting a portfolio as HTML, we get the following "error" on the screen:

Could not copy static file '/var/www/demo-mahara-org-prod-mahara/releases/20151111220737/theme/views.css'

htdocs/theme/views.css was removed in commit: 7bbb9da3d0719e01baf412dac4eb37bf027ebb7e ( https://git.mahara.org/mahara/mahara/commit/7bbb9da3d0719e01baf412dac4eb37bf027ebb7e )

as it's no longer required. Yet, the export is still requiring it in:

htdocs/export/html/lib.php::copy_static_files() -

       $filestocopy = array(
           get_config('docroot') . 'theme/views.css' => $staticdir . 'views.css',
       );

See original description
Revision history for this message
Ghada El-Zoghbi (ghada-z) wrote :

Also, the generated export files refer to (i.e. page's index.php file):

<link rel="stylesheet" type="text/css" href="../../static/views.css">

which is coming from

/htdocs/theme/raw/plugintype/export/html/templates/header.tpl

Aaron Wells (u-aaronw)
tags: added: export html regression
description: updated
Revision history for this message
Robert Lyon (robertl-9) wrote :

The patch https://reviews.mahara.org/#/c/5725/

has already solved part of this bug's problem and

https://reviews.mahara.org/#/c/5724/

removes the link from the template, once they pass this bug should be fixed

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5759

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5724
Committed: https://git.mahara.org/mahara/mahara/commit/01f8970947a3325a692fa8c481a9c0d0812680e4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 01f8970947a3325a692fa8c481a9c0d0812680e4
Author: Robert Lyon <email address hidden>
Date: Tue Nov 17 12:13:20 2015 +1300

Bug 739528, Bug 1515826: Adding actual theme css files

And getting them to display in the export html files

behatnotneeded

Change-Id: I881817dfb94d78a1fd2ac8b0e85b3ebed83b42cf
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5759
Committed: https://git.mahara.org/mahara/mahara/commit/30904f504d876248ad14b524b8cb25638e268eab
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 30904f504d876248ad14b524b8cb25638e268eab
Author: Robert Lyon <email address hidden>
Date: Tue Nov 17 12:13:20 2015 +1300

Bug 739528, Bug 1515826: Adding actual theme css files

And getting them to display in the export html files

behatnotneeded

Change-Id: I881817dfb94d78a1fd2ac8b0e85b3ebed83b42cf
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.