Mahara

Have require of pieform more centralised

Bug #1522659 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 16.04.0

Bug Description

Discovered when fixing another problem that some pages get their Pieform class via the require_once('pieforms/pieform.php'); via the auth_check_required_fields() function, while all the others get it via thier own require_once('pieforms/pieform.php'); within the top of the file.

When all we need is for is the pieform() function that calls the Pieform class to make sure the required file is included.

So will submit a code tidying up patch

Tags: api pieforms
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5816

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Though this bug is "low" priority, it's a prerequiset for the fix for Bug 1522660, which is a higher-priority performance improvement bug.

tags: added: api pieforms
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5816
Committed: https://git.mahara.org/mahara/mahara/commit/eb396d025e3d26f639da506e948a1a6bd3cd95d0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit eb396d025e3d26f639da506e948a1a6bd3cd95d0
Author: Robert Lyon <email address hidden>
Date: Fri Dec 4 15:02:40 2015 +1300

Bug 1522659: Centeralising the require to pieform file

behatnotneeded - existing tests should suffice

Change-Id: I69a59b5f70bc6e5e3379106faf975f9c99af07b0
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.