Meld syntax highlighting does not work

Same version works for me, comparing C++ and Ruby files. Perhaps it would be useful if you mentioned what your file types and file names are. Meld does not syntax highlight my C++ files if they are called *.bak, but I think that's fair.

OK, I've checked by manually comparing two C files, and it works fine. However, if I run it from my Perforce client (my usual use case), it does not. In this case, the filenames used are

/tmp/lucas(p4v)/itbr174_a.x.com_1666/software/main.br/scheduler/private/cet_interrupt#94.c and /tmp/lucas(p4v)/itbr174_a.x.com_1666/software/main.br/scheduler/private/cet_interrupt#95.c

Given the final .c extension, I think it's reasonable to expect C highlighting. I guess the problem is the brackets, the hash or the dots in the filename?

The hash causes syntax errors:

Traceback (most recent call last):
  File "/usr/lib/meld/task.py", line 131, in iteration
    ret = task()
  File "/usr/lib/meld/filediff.py", line 671, in _set_files_internal
    set_highlighting_enabled( self.textview[i].get_buffer(), files[i], self.prefs.use_syntax_highlighting )
  File "/usr/lib/meld/filediff.py", line 51, in set_highlighting_enabled
    mime_type = gnomevfs.get_mime_type( os.path.abspath(fname) )
RuntimeError: there was an error reading the file

At the command line the brackets also need to be escaped but I don't think that is your problem when meld is called from perforce. The hash is most likely the problem.

And since it looks like the hash is indicating a version number, you are stuck.

Looks like a bug in the function gnomevfs.get_mime_type to me.

The problem is in the following line in filediff.py:

mime_type = gnomevfs.get_mime_type( os.path.abspath(fname) )

The path is not properly escaped before being passed to get_mime_type. You can just replace this line by the following:

import urllib
mime_type = gnomevfs.get_mime_type( urllib.quote(os.path.abspath(fname)) )

Yep, that fixes the problem. Thanks for the tip.

Jonathan

I have submitted the bug report/patch to meld bugzilla.

Confirmed on hardy (1.1.5.1-2ubuntu1)

This bug was fixed in the package meld - 1.2-0ubuntu1

---------------
meld (1.2-0ubuntu1) jaunty; urgency=low

  * New upstream release. (LP: #283725)
  * debian/copyright:
    - Updated email of upstream author to what is stated in MAINTAINERS.
  * debian/control.in:
    - Bumped standards-version to 3.8.0.
  * debian/patches/html_patch_by_kai_willadsen.patch:
    - Removed, fixed upstream.
  * debian/patches/fix-fr-help-makefile.patch:
    - Ignore error when trying to install files from the non existent
      directory 'help/fr/figures'.
  * debian/patches/only-ignore-fully-blank-changes.patch:
    - Do not jump to the last blank change in blank changes are ignored and
      do not jump over blank changes if they are not ignored. Fixes bug that
      caused some differences to be ignored when using 'Up and 'Down' buttons.
      Patch by Martin Renold. (LP: #234259)
  * debian/patches/escape-paths.patch:
    - Escape paths so mime type is recoqnized correctly. Patch by Ivan
      Sergeyenko. Fixed in upstream development version. (LP: #152913)

 -- Michael Budde <email address hidden> Sat, 15 Nov 2008 13:35:17 +0100