OpenStack Object Storage (swift)

order of devices listed by swift-ring-builder is confusing

Bug #1536743 reported by clayg on 2016-01-21

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Object Storage (swift)	Fix Released	Low	Mingyu Li

Bug Description

The change to re-use device indexes to fill holes was great [1], but I think it made the order of devices listed by swift-ring-builder even more confusing [2].

I think we should order the output by (region, zone, ip, device)

1. https://review.openstack.org/#q,I1980ebdd9dc89848173d8ca2fe2afb74029dcfa2,n,z
2. https://gist.github.com/clayg/ac0ec87c98aa5a986537

Tags:

Samuel Merritt (torgomatic) on 2016-01-22

Changed in swift:
status:	New → Confirmed
importance:	Undecided → Low

Mingyu Li (mingyu-li-cn) on 2016-01-28

Changed in swift:
assignee:	nobody → Mingyu Li (mingyu-li-cn)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-02-09: Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/277956

Changed in swift:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-29: Fix merged to swift (master)

Reviewed: https://review.openstack.org/277956
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=a1134e4aa2cd40a95b9cda713dcc5ef5ffcc7e41
Submitter: Jenkins
Branch: master

commit a1134e4aa2cd40a95b9cda713dcc5ef5ffcc7e41
Author: Mingyu Li <li.mingyu@99cloud.net>
Date: Wed Feb 10 00:19:17 2016 +0800

Order devices in the output of swift-ring-builder

    After the change to reuse device id's [1], the order of devices in the
    output of swift-ring-builder is confusing. This patch list the devices
    in order of (region, zone, ip, device).
    The effect of this patch is as illustrated in [2].

This patch also partially fix Bug 1545016.

1. https://review.openstack.org/#/c/265461/
2. https://github.com/MicrowiseOnGitHub/tempfiles/blob/master/reorder_ring_output

    Change-Id: I564ed1b8d0cd4a6250649689b1bce7ad3574fe57
    Partial-Bug: 1545016
    Closes-Bug: 1536743