OpenStack Object Storage (swift)

A mistake in the help message of swift-ring-builder remove

Bug #1545016 reported by Mingyu Li on 2016-02-12

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Object Storage (swift)	Fix Released	Low	Unassigned

Bug Description

If you type “swift-ring-builder <builder_file> remove” in the command line, it will return the help message as shown below:

swift-ring-builder <builder_file> remove <search-value> [search-value ...]

swift-ring-builder <builder_file> search
--region <region> --zone <zone> --ip <ip or hostname> --port <port>

...

Apparently, the word "search" should be "remove" here.

This bug affects almost all the active branches of Swift including stable/kilo, stable/liberty and master.

See original description

Tags:

Mingyu Li (mingyu-li-cn) on 2016-02-12

description:

updated

Revision history for this message

clayg (clay-gerrard) wrote on 2016-02-12:

yup, for sure - probably some code is trying to be DRY and borrow the help text from the search command - it can probably be turned into a template and the two commands can format it with the right "command"

Changed in swift:
importance:	Undecided → Medium
status:	New → Confirmed
importance:	Medium → Low

Mingyu Li (mingyu-li-cn) on 2016-02-13

Changed in swift:
assignee:	nobody → Mingyu Li (mingyu-li-cn)

OpenStack Infra (hudson-openstack) on 2016-02-18

Changed in swift:
status:	Confirmed → In Progress

Revision history for this message

Paul Dardeau (paul-dardeau) wrote on 2016-05-19:

Duplicate of 1571312

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-29: Fix merged to swift (master)

Reviewed: https://review.openstack.org/277956
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=a1134e4aa2cd40a95b9cda713dcc5ef5ffcc7e41
Submitter: Jenkins
Branch: master

commit a1134e4aa2cd40a95b9cda713dcc5ef5ffcc7e41
Author: Mingyu Li <li.mingyu@99cloud.net>
Date: Wed Feb 10 00:19:17 2016 +0800

Order devices in the output of swift-ring-builder

    After the change to reuse device id's [1], the order of devices in the
    output of swift-ring-builder is confusing. This patch list the devices
    in order of (region, zone, ip, device).
    The effect of this patch is as illustrated in [2].

This patch also partially fix Bug 1545016.

1. https://review.openstack.org/#/c/265461/
2. https://github.com/MicrowiseOnGitHub/tempfiles/blob/master/reorder_ring_output

    Change-Id: I564ed1b8d0cd4a6250649689b1bce7ad3574fe57
    Partial-Bug: 1545016
    Closes-Bug: 1536743

Revision history for this message

Kota Tsuyuzaki (tsuyuzaki-kota) wrote on 2017-09-12:

This was fixed with https://review.openstack.org/#/c/323408/