Should run pep8 on oslo_messaging/tests

Bug #1540981 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Undecided
Davanum Srinivas (DIMS)

Bug Description

Without running pep8 on the oslo_messaging/tests dir, obvious whitespace failures like this are getting through (even though review should have caught this):

https://review.openstack.org/#/c/262205/2/oslo_messaging/tests/functional/test_functional.py

The exclusion list is here:

https://github.com/openstack/oslo.messaging/blob/5a78019439039cf428abb56fa4e981e30ecc5f5f/tox.ini#L48

Matt Riedemann (mriedem)
tags: added: low-hanging-fruit
Changed in oslo.messaging:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.messaging (master)

Reviewed: https://review.openstack.org/275314
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=44c60cf7e7d73eb5f5daa046d22b0fb9e19554b7
Submitter: Jenkins
Branch: master

commit 44c60cf7e7d73eb5f5daa046d22b0fb9e19554b7
Author: Davanum Srinivas <email address hidden>
Date: Tue Feb 2 11:34:01 2016 -0500

    Enable pep8 on oslo_messaging/tests

    Somehow we sneaked in a change to ignore pep8 on tests/ directory.

    Let's cleanup the code and re-enable pep8

    Closes-Bug: #1540981
    Change-Id: Ic002134a0d0c498991b062466e00068d6ac1f1ab

Changed in oslo.messaging:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/oslo.messaging 4.2.0

This issue was fixed in the openstack/oslo.messaging 4.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.