Ubuntu
stress-ng package

stress-ng: clean up on tests that use prime strides don't remove all files

Bug #1547004 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
stress-ng (Ubuntu)
Fix Released
High
Colin Ian King

Bug Description

using a prime stride is a good mechanism to step around files in a directory in a non-sequential manner, however, the implementation is broken because the large prime being used to do the striding wraps on 64 bit integers causing aliasing and hence not hitting all files.

Use a smaller prime and ensure that the number of files is not a multiple of this prime to ensure the striding always works correctly and allows us to remove all the files.

Colin Ian King (colin-king)
Changed in stress-ng (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed http://kernel.ubuntu.com/git/cking/stress-ng.git/commit/?id=486f24fcd96cb6274dcef64f01f126328d8ea087

Changed in stress-ng (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package stress-ng - 0.05.17-1

---------------
stress-ng (0.05.17-1) unstable; urgency=medium

  * Makefile: bump version
  * stress-aio: don't cancel the signal handler before exiting (LP: #1547108)
  * stress-lockf: don't return failure if we get a timeout (LP: #154107)
  * stress-aio: don't return failure if we get a timeout (LP: #1547090)
  * Check for ENOMEM ENOSPC errors during init (LP: #1547062)
  * make stress_temp_dir_mk and stress_temp_dir_rm return -errno on failure
  * stress-dentry: fix file striding on clean-up (LP: #1547004)
  * Add stress_get_prime64 to stress-ng header
  * Add stress_get_prime64 to find a prime for filename striding
  * typedef possibly missing __kernel_long_t and __kernel_ulong_t
  * Add <linux/posix_types.h> for linux builds
  * stress-aio-linux: fix clang scan-build warning
  * Makefile: only do build time config detection when building target

 -- Colin King <email address hidden> Thu, 18 Feb 2016 17:52:11 +0000

Changed in stress-ng (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.