Please merge efax-gtk (3.0.15-1) from Debian unstable (main)

Bug #155950 reported by Cesare Tirabassi
4
Affects Status Importance Assigned to Milestone
efax-gtk (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: efax-gtk

Please merge efax-gtk (3.0.15-1) from Debian unstable (main)

Changed in efax-gtk:
importance: Undecided → Wishlist
status: New → Confirmed
Changed in efax-gtk:
assignee: nobody → nxvl
Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

I think i have made the merge (my first one) here is the debdiff i hope it's good.
I also need to fill a debian bug, because the entry menu on "debian/menu" is buggy.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Resolv some problems.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Sorry about last debdiff, don't consider it.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Many thanks for your work Nicolas. Its very good but there are still few things that I would correct:

1) Good work in cleaning the debdiff, but you should also remove these:

diff -u efax-gtk-3.0.15/config.guess efax-gtk-3.0.15/config.guess
diff -u efax-gtk-3.0.15/config.sub efax-gtk-3.0.15/config.sub

2) Instead of just saying "Merged the changes from revision 3.0.14-1ubuntu1" I would explicitly list them.
I think its easier to keep track of them for the future than to oblige the next reviewer to search for them.

3) Instead of "Update the debian/menu according to the previus version of the package" I would word it as "Reverse incorrect debian maintainer change to debian/menu to the ubuntu version one"

Once corrected please subscribe u-u-s for sponsoring, set status as confirmed and de-assign yourself (see https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue).

Changed in efax-gtk:
status: Confirmed → Incomplete
Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Ok, i have made the changes you ask for, here is the new debdiff.

Changed in efax-gtk:
status: Incomplete → In Progress
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

Uploaded. Thanks for your contribution.

Changed in efax-gtk:
assignee: nxvl → nobody
status: In Progress → Fix Committed
Revision history for this message
Cesare Tirabassi (norsetto) wrote :

efax-gtk (3.0.15-1ubuntu1) hardy; urgency=low

  * Merge from debian unstable, remaining changes:
    - Reverse incorrect debian maintainer change to debian/menu
      to the ubuntu one from version 3.0.14-1ubuntu1
    - Add icon "stock_send-fax.xpm" from gnome-icon-theme in /debian
    - Add 01-efax-gtk.desktop.dpatch patch in debian/patches
    - Add dpatch support in debian/control and debian/rules
    - Add debian/dirs
    - Modify Maintainer value to match Debian-Maintainer-Field Spec

Changed in efax-gtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.