White screen when copying collection / page

Robert, can you please take a look? I can't replicate it neither with regular URLs nor clean URLs.

Darren: Do you have any more testing information?

This is on an RHEL6 server, PHP 5.3.3, database upgraded from Mahara 1.10.1.

I've attached a diff of my devel installation, just in case there's something in there mucking up the works. There shouldn't be anything causing the issue, though, since it's local language file changes, a couple of social plugins, and a theme.

I first found this when I was attempting to copy a collection at the institution level. But could replicate it within group collections and individual pages and collections as well.

Darren, you mentioned you have some social plugins. Are there any blocks on the pages? What plugins are these? Have they been fully upgraded to 15.10/16.04 architecture?

The plugins are: Facebooklike, twittertweet, linkedinshare, and linkedinprofile. I'll try removing these plugins tomorrow and see if it makes any difference.

Patch for "master" branch: https://reviews.mahara.org/6332

Hi Darren,

Can you let me know what types of blocks are on the pages of the collection that you are trying to copy?

The code around that artefact_get_descendants() line deals with the copying of journal/blog blocks that are set to full copy.

I am also unable to replicate but have added a patch that should solve the issue for those having it. It does the same as your patch except it calls the artefact/lib.php only if we need to call artefact_get_descendents()
https://reviews.mahara.org/#/c/6332/

Can you please test to see if this fix works for you?

Cheers

Robert

Tried with a variety of collections/pages that primarily consist of text/note blocks.

Here's an example of one collection that causes the white screen:

https://portfolio.elab.athabascau.ca/view/view.php?id=7315

As you can see, nothing special in that collection aside from the twittertweet and facebooklike blocks.

Thanks for sharing that collection, Darren. Were it possible that you send me a Leap2A export of the collection (<email address hidden>)? I still can't replicate the problem. I thought that the navigation block might be the issue as that references other pages in the collection, but that works fine for me.

Being able to work with your collection might shed some light on things more quickly.

Hi Darren,

Thanks for the Leap2A files. I can copy your 16.04 collection without problems, but when I copy the 1.10 one on 16.04 I also get a white screen. That will hopefully help Robert to dig deeper.

Cheers
Kristina

Ok, from what I've found this copy issue only exists if you copy a page/collection from another user using either the
 Portfolio -> Page 'Copy a page' button or Portfolio -> Collection 'Copy a collection' button that takes you to the 'Copy a page or collection' page and you click the copy button there for an item.

If you copy a page/collection via the copy link on the page itself it works fine.

The fix here https://reviews.mahara.org/#/c/6332/ fixes the issue.

To test:

1) Create a page and add a 'note' block to it
2) Share the page with registered users and allow copying from advanced options
3) Log in as another user - go to the page and click 'copy' - the page copies fine
4) Go to Portfolio -> Pages and click 'Copy a page' then click the copy button next to the page owned by the other user - page fails to copy.

With patch in place both ways should copy as expected

Reviewed: https://reviews.mahara.org/6332
Committed: https://git.mahara.org/mahara/mahara/commit/c8252bcc5cc6cf5052a12ebbfe45fb79af125155
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c8252bcc5cc6cf5052a12ebbfe45fb79af125155
Author: Robert Lyon <email address hidden>
Date: Wed Apr 13 16:51:16 2016 +1200

Bug 1569552: Require artefact lib when copying blocks

When the block needs to copy child artefacts. Another instance where
we don't include all the plugins on page load anymore.

behatnotneeded

Change-Id: I231325e0f17091da68fbd7a88d7882342f5a5d68
Signed-off-by: Robert Lyon <email address hidden>

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6405

Reviewed: https://reviews.mahara.org/6405
Committed: https://git.mahara.org/mahara/mahara/commit/e1763ca4ae48769ebdceb5eb28a1930b3c22d578
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit e1763ca4ae48769ebdceb5eb28a1930b3c22d578
Author: Robert Lyon <email address hidden>
Date: Wed Apr 13 16:51:16 2016 +1200

Bug 1569552: Require artefact lib when copying blocks

When the block needs to copy child artefacts. Another instance where
we don't include all the plugins on page load anymore.

behatnotneeded

Change-Id: I231325e0f17091da68fbd7a88d7882342f5a5d68
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c8252bcc5cc6cf5052a12ebbfe45fb79af125155)