show the gpg long keyid (instead of the short) on profile pages
Bug #1576142 reported by
Mattia Rizzolo
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Colin Watson | ||
Bug Description
short GPG key id are nowadays not considered secure anymore, as they are really easy have them clash.
Please show the long key id instead.
Related branches
lp:~cjwatson/launchpad/show-signing-key-fingerprints
- William Grant: Approve (code)
-
Diff: 666 lines (+90/-74)23 files modifiedlib/lp/archiveuploader/dscfile.py (+1/-1)
lib/lp/registry/browser/configure.zcml (+1/-1)
lib/lp/registry/browser/tests/test_gpgkey.py (+1/-1)
lib/lp/registry/model/gpgkey.py (+3/-2)
lib/lp/registry/stories/gpg-coc/xx-gpg-coc.txt (+30/-23)
lib/lp/registry/stories/gpg-coc/xx-ubuntu-codeofconduct-signer.txt (+2/-1)
lib/lp/registry/stories/person/xx-person-editgpgkeys-invalid-key.txt (+12/-10)
lib/lp/registry/stories/person/xx-person-home.txt (+2/-2)
lib/lp/registry/templates/codeofconduct-list.pt (+2/-1)
lib/lp/registry/templates/person-editpgpkeys.pt (+2/-2)
lib/lp/registry/templates/person-portlet-contact-details.pt (+1/-1)
lib/lp/services/gpg/doc/gpghandler.txt (+2/-2)
lib/lp/services/gpg/handler.py (+3/-2)
lib/lp/services/gpg/interfaces.py (+3/-2)
lib/lp/services/verification/browser/logintoken.py (+2/-2)
lib/lp/services/verification/browser/tests/logintoken-views.txt (+2/-1)
lib/lp/services/verification/emailtemplates/validate-gpg.txt (+1/-1)
lib/lp/services/verification/model/logintoken.py (+2/-1)
lib/lp/services/webservice/wadl-to-refhtml.xsl (+1/-1)
lib/lp/soyuz/doc/fakepackager.txt (+7/-7)
lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt (+2/-2)
lib/lp/soyuz/tests/fakepackager.py (+7/-7)
lib/lp/testing/gpgkeys/__init__.py (+1/-1)
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| tags: | added: lp-registry |
| Changed in launchpad: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Colin Watson (cjwatson) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Sadly not quite as trivial as it might seem, because the keyid is stored in a database column and switching to the long keyid would require some data migration.