demote virtualbox and reverse dependencies in yakkety

Demoting packages to yakkety-proposed:
 virtualbox 5.0.18-dfsg-2build1 in yakkety
 virtualbox-ext-pack 5.0.20-1 in yakkety
 testdrive 3.27-0ubuntu1 in yakkety
Comment: lp: #1578424, temporarily demote virtualbox and rdeps
3 packages successfully demoted.

virtualbox FTBFS on yakkety amd64, i386 builds fine.

/«PKGBUILDDIR»/src/VBox/Runtime/common/log/logellipsis.cpp:1:0: error: code model kernel does not support PIC mode
 /* $Id: logellipsis.cpp $ */
 ^

Virtualbox's build system mostly ignores FLAGS set in the environment:
https://qa.debian.org/bls/packages/v/virtualbox.html

I made the following change to debian/LocalConfig.kmk:

@@ -14,3 +14,4 @@
 VBOX_JAVA_HOME := /usr/lib/jvm/default-java
 VBOX_PATH_DOCBOOK_DTD := /usr/share/xml/docbook/schema/dtd/4/
 VBOX_WITH_VBOX_IMG = 1
+VBOX_GCC_R0_OPT := -O2 -fno-PIC

...and the build continued further, failing with:

/«PKGBUILDDIR»/src/VBox/Devices/PC/ipxe/src/arch/i386/interface/pcbios/int13.c: In function ‘int13_hook’:
/srv/scratch/debian-packages-dev/virtualbox/virtualbox-5.0.20-dfsg/src/VBox/Devices/PC/ipxe/src/arch/i386/interface/pcbios/int13.c:1466:2: warning: asm operand 0 probably doesn’t match constraints
  __asm__ __volatile__ (
  ^

...which seems very similar to the FTBFS in syslinux (LP: #1579023)

I tried patching the same place as in syslinux:

--- a/src/VBox/Devices/PC/ipxe/src/Makefile
+++ b/src/VBox/Devices/PC/ipxe/src/Makefile
@@ -4,7 +4,7 @@
 #

 CLEANUP :=
-CFLAGS :=
+CFLAGS := -fno-PIE
 ASFLAGS :=
 LDFLAGS :=
 HOST_CFLAGS :=

...but virtualbox doesn't use that Makefile.
Injecting -fno-PIE one level up allowed the build to continue further.

--- a/src/VBox/Devices/PC/ipxe/Makefile.kmk
+++ b/src/VBox/Devices/PC/ipxe/Makefile.kmk
@@ -130,6 +130,7 @@
  -Wall \
  -W \
  -Wformat-nonliteral \
+ -fno-PIE \
  $(VBOX_GCC_fno-stack-protector) \
  $(VBOX_GCC_fno-dwarf2-cfi-asm) \
  $(VBOX_GCC_Wno-address)

I also tried something like this:

- $(QUIET)$(APPEND) '$@' 'VBOX_GCC_fno-stack-protector ?= $(call VBOX_GCC_CHECK_CC,-fno-stack-protector,)'
+ $(QUIET)$(APPEND) '$@' 'VBOX_GCC_fno-stack-protector := $(call VBOX_GCC_CHECK_CC,-fno-stack-protector,)'
+ $(QUIET)$(APPEND) '$@' 'VBOX_GCC_fno-stack-protector += $(call VBOX_GCC_CHECK_CC,-fno-pie,)'

it adds the flag in the correct place (I guess where no stack protector is needed, also no-pie is)

it fails with:
error: Missing # define g_kLdrRdrFileOps RT_MANGLER(g_kLdrRdrFileOps)

I saw that one too:

error: Missing # define g_kLdrRdrFileOps RT_MANGLER(g_kLdrRdrFileOps)

I think that one is PIC related again.

Status changed to 'Confirmed' because the bug affects multiple users.

See my attached patch. With this patch I was able to compile VBox on Ubuntu 16.10-amd64. These patches are also part of the public repository at https://www.virtualbox.org/browser/vbox/trunk, see changesets 61080, 61081, 61082, 61083.

Thanks Frank! Uploaded on my ppa, and I'll upload on Debian/Ubuntu shortly!