Snapcraft

snapcraft clean -s strip doesn't show the deprecation message

Bug #1590256 reported by Leo Arias
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Snapcraft
Fix Released
Critical
Sergio Schvezov
Snapcraft 2.10.1
snapcraft (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Ubuntu xenial-updates
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

The strip step was renamed to prime. When the old step is run a deprecation message is displayed; but when it is cleaned, an error is shown.

$ snapcraft clean -s strip
'strip' is not a valid step for part ...

The deprecation message should be displayed also when the strip is cleaned.

[Impact]

 * Users trying to clean the strip step will get an error and no indication about the rename.

[Test Case]

 * Run snapcraft clean -s strip
 * Make sure that you get the step run and a deprecation message.

[Regression Potential]

 * It could affect the clean prime step. There are tests to avoid that, but a manual check would be good.

See original description
Leo Arias (elopio)
Changed in snapcraft:
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.11
Leo Arias (elopio)
Changed in snapcraft:
importance: Medium → High
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

https://github.com/ubuntu-core/snapcraft/pull/556

Changed in snapcraft:
status: Triaged → In Progress
assignee: nobody → Sergio Schvezov (sergiusens)
importance: High → Critical
milestone: 2.11 → 2.10.1
Leo Arias (elopio)
description: updated
Sergio Schvezov (sergiusens)
Changed in snapcraft:
status: In Progress → Fix Committed
Changed in snapcraft (Ubuntu Xenial):
milestone: none → xenial-updates
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Leo, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapcraft (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

This comes from LP: #1582515

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.10.1+16.10

---------------
snapcraft (2.10.1+16.10) yakkety; urgency=medium

  * Backwards compatible clean with strip (#556) (LP: #1590256)

 -- Sergio Schvezov <email address hidden> Wed, 08 Jun 2016 16:32:27 -0300

Changed in snapcraft (Ubuntu Yakkety):
status: New → Fix Released
Revision history for this message
Leo Arias (elopio) wrote :

Tested in an up-to-date xenial:

- Update to snapcraft 2.10.1
- snapcraft init
- snapcraft
- snapcraft clean
- The priming area is mentioned, instead of the striping area.
- snapcraft prime
- The prime step is executed, no warning.
- snapcraft strip
- A deprecation warning is printed. The step is not reexecuted.
- snapcraft clean -s prime
- The prime step is clean up, no warning.
- snapcraft strip
- A deprecation warning is printed. The prime step is executed.
- snapcraft clean -s strip
- A deprecation warning is printed. The prime step is cleaned.

All good, I'm marking this as done.

Thanks Steve!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapcraft - 2.10.1

---------------
snapcraft (2.10.1) xenial; urgency=medium

  * Backwards compatible clean with strip (#556) (LP: #1590256)

 -- Sergio Schvezov <email address hidden> Wed, 08 Jun 2016 16:32:27 -0300

Changed in snapcraft (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Sergio Schvezov (sergiusens)
Changed in snapcraft:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.