[SRU] Update walinuxagent to 2.1.3 in trusty

Bug #1590751 reported by Dan Watkins
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
walinuxagent (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Won't Fix
Medium
Dan Watkins

Bug Description

[Impact]

Version 2.1.2 introduced support for Azure Stack; version 2.1.2 or greater is needed in order for Ubuntu to provision in that environment.

[Test case 1]: Upgrade testing
1.) Launch instance on Azure
2.) Upgrade walinuxagent from -proposed
3.) Confirm that "waagent" is running, check /var/log/waagent.log
4.) Reboot, repeat step 3
5.) Capture instance and provsion new instances; repeat step 3

[Test Case 2]: New instance
1.) Build new cloud image from -proposed
2.) Boot instance
3.) Confirm that instance provisioned

[Upstream Testing]
The Canonical Cloud Image team has been working with Microsoft to ensure that this package is well tested. Validation will be performed by both Microsoft and the Canonical Cloud Image team.

[Regression Potential]
Currently, WALinuxAgent uses Python 2. With the 2.1.x branch, WALinuxAgent started using Python 3.

This version has been in use on xenial since release, and wily since March, so it is known to work. Azure consider Ubuntu to be a flagship platform, so will be active in addressing any regressions that are found.

Dan Watkins (oddbloke)
description: updated
Changed in walinuxagent (Ubuntu):
status: New → Fix Released
Changed in walinuxagent (Ubuntu Trusty):
assignee: nobody → Dan Watkins (daniel-thewatkins)
status: New → In Progress
Dan Watkins (oddbloke)
description: updated
description: updated
Revision history for this message
Dan Watkins (oddbloke) wrote :

The attached debdiff has been tested from a PPA using both of the given regression cases.

Revision history for this message
Steve Langasek (vorlon) wrote :

I cannot apply the provided patch cleanly against the 2.0.16-0ubuntu2 package in trusty-updates. Please provide a debdiff relative to the 2.1.3-0ubuntu4 package version in xenial/yakkety.

Changed in walinuxagent (Ubuntu Trusty):
status: In Progress → Incomplete
Revision history for this message
Dan Watkins (oddbloke) wrote :

Hmm, that seems like the obvious thing to have done now you say it. Attached.

Changed in walinuxagent (Ubuntu Trusty):
status: Incomplete → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote :

Debian packaging delta vs. the current trusty version:

--- walinuxagent-2.0.16/debian/ephemeral-disk-warning.conf 2016-03-08 08:29:03.000000000 -0800
+++ walinuxagent-2.1.3/debian/ephemeral-disk-warning.conf 2016-03-07 11:15:40.000000000 -0800
@@ -43,6 +43,7 @@

 This warning is written each boot; to disable it:
     echo "manual" | sudo tee /etc/init/ephemeral-disk-warning.override
+ sudo systemctl disable ephemeral-disk-warning.service

 EOF
         chmod 0444 $warn_file

This command will fail on trusty, which does not use (or have) systemd.

I've reverted this change locally for the upload to trusty.

--- walinuxagent-2.0.16/debian/patches/fix_shebangs.patch 1969-12-31 16:00
:00.000000000 -0800
+++ walinuxagent-2.1.3/debian/patches/fix_shebangs.patch 2016-02-18 12:26
:20.000000000 -0800
@@ -0,0 +1,24 @@
+--- a/setup.py
++++ b/setup.py
+@@ -1,4 +1,4 @@
+-#!/usr/bin/env python
++#!/usr/bin/env python3n3n3
+ #
+ # Microsoft Azure Linux Agent setup.py
+ #

So... that's a bit wrong, but fortunately the dh-python build system doesn't care about the shebang and instead invokes its version of python3 explicitly. Should be fixed in yakkety at some point, but not a blocker for SRU.

Looks fine otherwise. Uploading.

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted walinuxagent into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/walinuxagent/2.1.3-0ubuntu4~ubuntu14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in walinuxagent (Ubuntu Trusty):
status: In Progress → Fix Committed
Revision history for this message
Daniel Sol (danis) wrote :

Hi, we found a bug in 2.1.3:https://github.com/Azure/WALinuxAgent/issues/238

Please halt the work on this bug for 2.1.3.

This has been fixed in 2.1.5, please can you test with this instead, the RC is available.

https://github.com/Azure/WALinuxAgent/releases/tag/v2.1.5.rc2

I will raise a separate bug for that.

Thanks,

Mathew Hodson (mhodson)
tags: added: upgrade-software-version
Changed in walinuxagent (Ubuntu):
importance: Undecided → Medium
Changed in walinuxagent (Ubuntu Trusty):
importance: Undecided → Medium
tags: added: verification-failed
Revision history for this message
Martin Pitt (pitti) wrote : Proposed package removed from archive

The version of walinuxagent in the proposed pocket of Trusty that was purported to fix this bug report has been removed because the bugs that were to be fixed by the upload were not verified in a timely (105 days) fashion.

Changed in walinuxagent (Ubuntu Trusty):
status: Fix Committed → Won't Fix
Revision history for this message
Rolf Leggewie (r0lf) wrote :

#6, it would be good if your referenced the bug number for 2.1.5 in here.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.