Generate UA override lists at build time to allow variable substitutions
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Unassigned | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy | ||
Bug Description
The UA override lists are plain javascript files shipped by qml-module-
"Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4) AppleWebKit/537.36 Chromium/
It would be useful if we could generate those files at build time, and allow for variables to be replaced. For example, the above UA string would become:
"Mozilla/5.0 (Linux; Ubuntu @UBUNTU_VERSION@ like Android 4.4) AppleWebKit/
Not all overrides would be required to use those variables, if necessary some version numbers could remain hardcoded.
Related branches
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- David Barth (community): Approve
-
Diff: 200 lines (+57/-27)10 files modified.bzrignore (+2/-0)
CMakeLists.txt (+5/-0)
debian/control (+2/-1)
src/Ubuntu/CMakeLists.txt (+8/-0)
src/Ubuntu/Components/Extras/Browser/CMakeLists.txt (+8/-0)
src/Ubuntu/Web/CMakeLists.txt (+8/-0)
src/Ubuntu/Web/ua-overrides-desktop.js.in (+8/-8)
src/Ubuntu/Web/ua-overrides-mobile.js.in (+10/-10)
src/Ubuntu/chromium-version.qml (+6/-0)
tests/unittests/qml/CMakeLists.txt (+0/-8)
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Olivier Tilloy (osomon) |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Medium |
| milestone: | none → 13 |
| status: | New → Fix Committed |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
* Generate UA override list files at build time to un-hardcode ubuntu
and chromium version numbers. (LP: #1591220)
* Fix one flaky autopilot test. (LP: #1591120)
* Temporarily skip tests on arm64 to unblock package build without
oxide. (LP: #1585942)
* Update the target that lists non-compiled files.
-- Olivier Tilloy <email address hidden> Fri, 01 Jul 2016 13:10:14 +0000