Login eror message shown twice

Bug #1592559 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

The error "There was an error with submitting this form. Please check the marked fields and try again." is shown twice.

This is because the login pieform is created / submitted twice to handle all the different auth complexity.

The easiest way to fix this is to take the form with 'login_submitted' variable in it and get it to display the error message within the login box itself.

So the two messages still exist but they make more sense now

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6600

no longer affects: mahara/16.04
no longer affects: mahara/15.10
no longer affects: mahara/15.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6600
Committed: https://git.mahara.org/mahara/mahara/commit/b05bf1b92d39708c9e54ab1b084e674c16a6a1fb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b05bf1b92d39708c9e54ab1b084e674c16a6a1fb
Author: Robert Lyon <email address hidden>
Date: Wed Jun 15 08:42:16 2016 +1200

Bug 1592559: Allow the login errors to appear above in login box.

behatnotneeded

Change-Id: I6acee18adefde9f8fcc805b31140a92fe3554c5f
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
no longer affects: mahara/16.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.