Ubuntu
dh-golang package

dh_makegolangshlibs breaks audit

Bug #1600399 reported by Steve Langasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dh-golang (Ubuntu)
Fix Released
High
Michael Hudson-Doyle

Bug Description

The latest archive rebuild test shows the audit package failing to build on all architectures with the following error:

This is because audit uses the golang dh addon for its go bindings, and dh_makegolangshlibs bypasses dh_makeshlibs entirely, resulting in no shlibs for the C libraries in this package.

I suggest that dh_makegolangshlibs needs a more subtle override, by generating its own golangshlibs as appropriate, but then calling dh_makeshlibs in a pass-through fashion in case there's anything that's not a go library that needs shlibs (so, calling dh_makeshlibs -X to exclude being rerun for the go shlibs).

Steve Langasek (vorlon)
Changed in dh-golang (Ubuntu):
assignee: nobody → Michael Hudson-Doyle (mwhudson)
importance: Undecided → High
status: New → Triaged
Revision history for this message
Steve Langasek (vorlon) wrote :

For bonus points, dh_makegolangshlibs should DTRT if debian/rules contains an override_dh_makeshlibs target.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Oops.

I think just calling dh_makeshlibs -Xlibgolang at the end of dh_makegolangshlibs would work pretty well, but I guess it's almost as easy and more correct to just -X the shared libraries we have done the work for.

Not at all sure how to do the bonus bit, AFAICT the overide_ rule detection is in /usr/bin/dh itself not in any library package (and is pretty hair-raising).

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Just uploaded a fix for this that runs dh_makegolangshlibs after rather than instead of dh_makeshlibs. Repeats a little bit of work but keeps everything else working (even override_dh_makeshlibs).

Changed in dh-golang (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dh-golang - 1.18ubuntu2

---------------
dh-golang (1.18ubuntu2) yakkety; urgency=medium

  * Run dh_makegolangshlibs after dh_makeshlibs rather than instead of it,
    fixing FTBFS when there are non-Go shared libraries in the package.
    (LP: #1600399)

 -- Michael Hudson-Doyle <email address hidden> Mon, 11 Jul 2016 12:28:51 +1200

Changed in dh-golang (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.