Raw theme table border style overrides user settings

Bug #1605110 reported by Mark Webster
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Mark Webster
16.04
Fix Released
Medium
Aaron Wells
16.10
Fix Released
Medium
Mark Webster

Bug Description

Table borders have been purposefully overridden by a style in the Raw theme (line 66 of /theme/raw/sass/features/_user-pages.scss), anything added by tinyMCE won't be used because of this.

Changed in mahara:
assignee: nobody → Mark Webster (mark-webster-v)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6740

Changed in mahara:
importance: Undecided → Medium
milestone: none → 16.10.0
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6740
Committed: https://git.mahara.org/mahara/mahara/commit/63f91a7ea8bd60c102e257c05678cc6d55e21683
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 63f91a7ea8bd60c102e257c05678cc6d55e21683
Author: Mark Webster <email address hidden>
Date: Thu Jul 21 10:00:12 2016 +0100

Bug 1605110: Raw theme table border style overrides user settings

Refactor the css to allow table border colours set by the user
in TinyMCE.

Adds table_style_by_css option to TinyMCE init in lib/web.php.

Adds TinyMCE patch https://github.com/tinymce/tinymce/pull/3080

behatnotneeded: Covered by existing tests

Change-Id: Iff67b93a4d8f41beaed30dffac34149e930c97ba
Signed-off-by: Aaron Wells <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6781

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6781
Committed: https://git.mahara.org/mahara/mahara/commit/61fd9cc8bf9541847f4e8641264ce199456a9dd5
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 61fd9cc8bf9541847f4e8641264ce199456a9dd5
Author: Mark Webster <email address hidden>
Date: Thu Jul 21 10:00:12 2016 +0100

Bug 1605110: Raw theme table border style overrides user settings

Refactor the css to allow table border colours set by the user
in TinyMCE.

Adds table_style_by_css option to TinyMCE init in lib/web.php.

Adds TinyMCE patch https://github.com/tinymce/tinymce/pull/3080

behatnotneeded: Covered by existing tests

Change-Id: Iff67b93a4d8f41beaed30dffac34149e930c97ba
Signed-off-by: Aaron Wells <email address hidden>
(cherry picked from commit 63f91a7ea8bd60c102e257c05678cc6d55e21683)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → none
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7542
Committed: https://git.mahara.org/mahara/mahara/commit/b2b238942749872b39c39859cebf1b9557010f23
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b2b238942749872b39c39859cebf1b9557010f23
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Mar 20 10:14:47 2017 +1300

Bug 1672893: Upgrading tinyMCE to v4.5.5, adding customizations

* Added all of the language packs
original commit: 259a86431ad1140e15288d39702cea885c08f3fe

* Removed all .min.js and .dev.js files
* Removed all files in 'classes' directory since they're packaged into tinymce.js
* Removed all .less files from skin
original commit for the 3 above: 442ade4e7c7cf991a4001ab8f7cc9d15e2b25890

* Added code to spellchecker/spellchecker.rpc to use $CFG->spellcheckerengine
original commit: a42e68b43e4a63db19569facae61898af1b86d3f

* Adding the 'aria-hidden="true"' to presentation icons
original commit: 4ac89c31a719a9f63be6555c4d1a094fd2b09d0e

* Bug 1605110: Modified the "table" plugin to style the table through CSS instead of HTML attributes
original commit: 63f91a7ea8bd60c102e257c05678cc6d55e21683

* Add TinyMCE imagebrowser plugin: plugins/imagebrowser/plugin.js

* adding
plugins/imagebrowser (originally added in commit 36bc9f7d26076d74ebc6cd0672441eed8ed9cd2d)
plugins/mathslate (originally added in commit 325cdfac3dfba40efbbad8cd306dcfb385674709)
plugins/tooltoggle (originally added in commit 2c490a70bfff677c0b95c0565d39162c8c9bc10d)
skins/light (we use it but it's not included in new versions any more)
README.Mahara

* included in new library version but not added in ours
plugins/lists source files
not needed since they are all included in plugin.js file in same directory
plugins/media source files
not needed since they are all included in plugin.js file in same directory
plugins/wordcount source files
not needed since they are all included in plugin.js file in same directory
plugins/toc, new plugin "Table of content"
themes/inlite, we don't nee this, we use modern theme
themes/modern source files
not needed since they are all included in theme.js file in same directory

* have been removed in new version
plugins/layer removed in v4.5.0
plugins/media/moxieplayer.swf removed in v4.5.0
tinymce.jquery.js removed in v4.3.4

behatnotneeded: no functionality change

Change-Id: I1feb60471037183ac718c3841fbcf19f123a1bdd

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.