Closing help options with 'X' causes cancel of form

Bug #1609142 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Son Nguyen

Bug Description

If I open the admin user edit page and change a field then click on help icon then click on the 'X' to close it I get the 'This page is asking you to confirm that you want to leave - data you have entered may not be saved.' message indicating to me that it is trying to submit the form.

If I don't change a form value the clicking on 'X' looks to reload the page, so looks to be doing the form 'cancel' option.

If I do this on the Institution edit page (where I first noticed it) it cancels the form and takes me to the institution list page.

I note that if I click on a help icon then click outside the help box it disappears and nothing bad happens, so this issue is only if the 'X' is clicked

Tags: regression
Robert Lyon (robertl-9)
summary: - Closing help options with 'X' causes canel of form
+ Closing help options with 'X' causes cancel of form
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6787

Revision history for this message
Aaron Wells (u-aaronw) wrote :

This is a regression introduced during the removal of MochiKit from mahara.js.

tags: added: regression
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6787
Committed: https://git.mahara.org/mahara/mahara/commit/db34349feef29ce01604d0bdb276248bb854bc3c
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit db34349feef29ce01604d0bdb276248bb854bc3c
Author: Son Nguyen <email address hidden>
Date: Wed Aug 3 10:15:35 2016 +1200

Bug 1609142: Fix click event handler for contextual help

behatnotneeded

Change-Id: I7675dbc105cf73a9eb3960529c582acffb8aad26

Aaron Wells (u-aaronw)
Changed in mahara:
status: Confirmed → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.