very hard to get going on windows

Bug #161082 reported by Robert Collins
2
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Fix Released
Medium
Kevin Light

Bug Description

Seems windows users find bzr-svn very hard to get going.
===
lifeless: a big problem for the ones stuck on windows :P
<lifeless> http://bazaar-vcs.org/BzrForeignBranches/Subversion has a
windows svn that works apparently .. ?
< lifeless> search for windows
< user> lifeless: yes, but that binding was build with VC2005, so it's
linked against MSVCR80, Python is linked against MSVCRT (VC2003) which
is the version use dot build python on windows...
< user> lifeless: it could blow up in your face if the binding frees
memory allocated by the interpreter... we are facing the same issue with
Ruby on Windows
===

Possibly a few more svn builds are all thats needed ?

 affects bzr-svn

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: New → Confirmed
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It may be nice to have just the required svn dlls + bzr-svn as (optional) part of the Windows installer.

Revision history for this message
Robert Collins (lifeless) wrote : bzr-svn as part of windows install?

On Sun, 2007-11-11 at 10:37 +0000, Jelmer Vernooij wrote:
> It may be nice to have just the required svn dlls + bzr-svn as
> (optional) part of the Windows installer.

Jelmer just suggested this in bug 161082 (bzr-svn hard to get going on
windows). I think this is a great idea. Alexander - what do you think?

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

Revision history for this message
Alexander Belchenko (bialix) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins пишет:
> On Sun, 2007-11-11 at 10:37 +0000, Jelmer Vernooij wrote:
>> It may be nice to have just the required svn dlls + bzr-svn as
>> (optional) part of the Windows installer.
>
> Jelmer just suggested this in bug 161082 (bzr-svn hard to get going on
> windows). I think this is a great idea. Alexander - what do you think?

I think that Lukas Lalinsky chose the right way with QBzr:
he created additional installer compatible with standalone bzr.exe
with required Qt/PyQt libraries *inside*.

I personally don't use neither svn nor bzr-svn so I can't predict
the weight of additional libraries in standalone bzr.exe distribution.
Furthermore, I can't test it in the appropriate way. I several times
look at the bzr-svn description at Bazaar wiki, and I should say
that I'm not completely understand situation with svn bindings and
patch from svn 1.5 (see Requirements section).

But it certainly doable in the QBzr's way.

If we want to ship bzr with batteries included I'd like to fix
https://bugs.launchpad.net/bzr/+bug/129298 first.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOJWnzYr338mxwCURAvXZAKCVSZFtp5ja+DRe6pjuMzYHuIEmqQCgiwqz
6Y2RMbMW9r0IyGoH1YhprdM=
=V4da
-----END PGP SIGNATURE-----

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Am Montag, den 12.11.2007, 20:04 +0200 schrieb Alexander Belchenko:
> Robert Collins пишет:
> > On Sun, 2007-11-11 at 10:37 +0000, Jelmer Vernooij wrote:
> >> It may be nice to have just the required svn dlls + bzr-svn as
> >> (optional) part of the Windows installer.
> >
> > Jelmer just suggested this in bug 161082 (bzr-svn hard to get going on
> > windows). I think this is a great idea. Alexander - what do you think?
>
> I think that Lukas Lalinsky chose the right way with QBzr:
> he created additional installer compatible with standalone bzr.exe
> with required Qt/PyQt libraries *inside*.
>
> I personally don't use neither svn nor bzr-svn so I can't predict
> the weight of additional libraries in standalone bzr.exe distribution.
> Furthermore, I can't test it in the appropriate way. I several times
> look at the bzr-svn description at Bazaar wiki, and I should say
> that I'm not completely understand situation with svn bindings and
> patch from svn 1.5 (see Requirements section).
In terms of file size, the svn libraries shouldn't be that much of an issue. In terms of maintainance, it's probably a bit harder - involves building subversion from scratch with the patches, and determining which files are needed for bzr-svn.

> But it certainly doable in the QBzr's way.
>
> If we want to ship bzr with batteries included I'd like to fix
> https://bugs.launchpad.net/bzr/+bug/129298 first.
I think it would be very nice to ship bzr with some of the common
plugins on Windows.

Cheers,

Jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Alexander Belchenko (bialix) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij пишет:
> I think it would be very nice to ship bzr with some of the common
> plugins on Windows.

Some people still have not broadband cheap internet, so the size matters.
Currently we have about 4.5MB for bare installer. And for some it's already big size, especially
because we release almost each month. So having separate package for plugins is good way too.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOLeUzYr338mxwCURAkrrAJsES97UHBgHpNj6dxj1+C5bHHN0fgCfSXaK
VxToKJVdZOyoDPrQU5eF8FA=
=zfTw
-----END PGP SIGNATURE-----

Revision history for this message
Erik Bågfors (zindar) wrote :

Since mac os leopard contains a python that works with bzr, I've been
thinking of doing an installer that contains bzr, bzr-svn, bzrtools,
rebase and perhaps a few other plugins. So any experience you can give
from doing the same for windows would be helpful.

/Erik

Sent from my iPhone

On 2007 nov 12, at 21.18, Jelmer Vernooij <email address hidden> wrote:

> Am Montag, den 12.11.2007, 20:04 +0200 schrieb Alexander Belchenko:
>> Robert Collins пишет:
>>> On Sun, 2007-11-11 at 10:37 +0000, Jelmer Vernooij wrote:
>>>> It may be nice to have just the required svn dlls + bzr-svn as
>>>> (optional) part of the Windows installer.
>>>
>>> Jelmer just suggested this in bug 161082 (bzr-svn hard to get
>>> going on
>>> windows). I think this is a great idea. Alexander - what do you
>>> think?
>>
>> I think that Lukas Lalinsky chose the right way with QBzr:
>> he created additional installer compatible with standalone bzr.exe
>> with required Qt/PyQt libraries *inside*.
>>
>> I personally don't use neither svn nor bzr-svn so I can't predict
>> the weight of additional libraries in standalone bzr.exe
>> distribution.
>> Furthermore, I can't test it in the appropriate way. I several times
>> look at the bzr-svn description at Bazaar wiki, and I should say
>> that I'm not completely understand situation with svn bindings and
>> patch from svn 1.5 (see Requirements section).
> In terms of file size, the svn libraries shouldn't be that much of
> an issue. In terms of maintainance, it's probably a bit harder -
> involves building subversion from scratch with the patches, and
> determining which files are needed for bzr-svn.
>
>> But it certainly doable in the QBzr's way.
>>
>> If we want to ship bzr with batteries included I'd like to fix
>> https://bugs.launchpad.net/bzr/+bug/129298 first.
> I think it would be very nice to ship bzr with some of the common
> plugins on Windows.
>
> Cheers,
>
> Jelmer
> --
> Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
> Jabber: <email address hidden>
>

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 161082] Re: very hard to get going on windows

Am Sonntag, den 11.11.2007, 10:37 +0000 schrieb Jelmer Vernooij:
> It may be nice to have just the required svn dlls + bzr-svn as
> (optional) part of the Windows installer.
Kevin Light is working on an installer.

  status inprogress
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Changed in bzr-svn:
status: Confirmed → In Progress
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Reassigning to Kevin Light.

Changed in bzr-svn:
assignee: nobody → klight
importance: Undecided → Medium
Revision history for this message
Kevin Light (klight) wrote :

I've made a Win32 installer build of bzr-svn-0.4.5 which includes subversion-1.4.6 python bindings built with the metze and latest memory leak fix patches applied.

You can find it at: http://home.comcast.net/bzr/bzr-svn-0.4.5-svn-1.4.6-setup-0.exe
MD5: dac13be21da5df8081d35c3a23e8f068

The metze patch required a slight modification to expose a missing SWIG export:
http://home.uploads.comcast.net/bzr/subversion-1.4.0-metze-python-bindings.patch

The memory leak patch relative to subversion trunk r28543:r28544:
http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c?r1=28543&r2=28544&pathrev=28544

A zip of the subversion 1.4.6 python bindings with the patches applied:
http://home.uploads.comcast.net/bzr/subversion-1.4.6-python-bindings.zip

NOTES:
    The bzr-svn tests (bzr selftest svn) will not run cleanly.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Kevin,

Am Montag, den 24.12.2007, 18:03 +0000 schrieb Kevin Light:
> I've made a Win32 installer build of bzr-svn-0.4.5 which includes
> subversion-1.4.6 python bindings built with the metze and latest memory
> leak fix patches applied.
>
> You can find it at: http://home.comcast.net/bzr/bzr-svn-0.4.5-svn-1.4.6-setup-0.exe
> MD5: dac13be21da5df8081d35c3a23e8f068
>
> The metze patch required a slight modification to expose a missing SWIG export:
> http://home.uploads.comcast.net/bzr/subversion-1.4.0-metze-python-bindings.patch
>
> The memory leak patch relative to subversion trunk r28543:r28544:
> http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c?r1=28543&r2=28544&pathrev=28544
>
> A zip of the subversion 1.4.6 python bindings with the patches applied:
> http://home.uploads.comcast.net/bzr/subversion-1.4.6-python-bindings.zip
Thanks!

> NOTES:
> The bzr-svn tests (bzr selftest svn) will not run cleanly.
What errors do you get when running the tests? They should in theory all pass on Windows.

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Kevin Light (klight) wrote :

Looks like I messed up two of the links in the previous post. Please remove the "uploads" in the home.uploads.comcast.net links.

The metze patch required a slight modification to expose a missing SWIG export:
http://home.comcast.net/bzr/subversion-1.4.0-metze-python-bindings.patch

A zip of the subversion 1.4.6 python bindings with the patches applied:
http://home.comcast.net/bzr/subversion-1.4.6-python-bindings.zip

Also I forgot to mention that the bindings do have DB (version 4.4) and SSL support. The bindings were also built using a Python 2.5 compatible build system (VC2003) meaning that no additional dll's are required.

I have attached the output of the tests on my system. The test results are the same if run from the build or if installed in a python environment.

Revision history for this message
Kevin Light (klight) wrote :

The Permission denied: xxx error is because Windows is hanging onto something in the svn-cache folders after the test has completed. shutil.rmtree called from the teardown function is failing causing the exception to be thrown. I'm trying to figure out how to get the test to "let go" of the files when it's done.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Am Dienstag, den 25.12.2007, 03:52 +0000 schrieb Kevin Light
> I have attached the output of the tests on my system. The test results
> are the same if run from the build or if installed in a python
> environment.
Thanks for posting that.
>
> ** Attachment added: "bzr selftest svn output"
> http://launchpadlibrarian.net/11059043/bzr-svn-selftest.txt
A couple of the errors appear to be related to the fact that there is no
executable bit on Windows. That should be fixable. Both Bazaar and
Subversion cache the executable bit if it is not supported by the
system.

There are apparently also some tests related to symlinks failing. I
wonder what we should do there. We could just skip them because it is
impossible to create symlinks on Windows...

There are some tests failing because apparently the pre-revprop-change
hook doesn't appear to be invoked at the moment. This should be fixable
by providing a Windows-specific hook inside the testcase setup code.

I'll see how much of those I can fix.

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Kevin,

The links to the Subversion bindings zip file and the updated patch you
posted appear to have gone away. I get a 404 when I go to them. Any
chance you can upload them again? I could probably mirror them if you
don't have the space available.

Cheers,

Jelmer

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Kevin Light (klight) wrote :

Sorry for the delay,

The bindings: http://home.comcast.net/~klight/bzr/subversion-1.4.6-python-bindings.zip
The installer: http://home.comcast.net/~klight/bzr/bzr-svn-0.4.6-svn-1.4.6-setup-0.exe

I've thrown an index in the folder to help to keep the files visible:
http://home.comcast.net/~klight/bzr

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

On Mon, Jan 28, 2008 at 01:23:48PM -0000, Kevin Light wrote:
> Sorry for the delay,

> The bindings: http://home.comcast.net/~klight/bzr/subversion-1.4.6-python-bindings.zip
> The installer: http://home.comcast.net/~klight/bzr/bzr-svn-0.4.6-svn-1.4.6-setup-0.exe

> I've thrown an index in the folder to help to keep the files visible:
> http://home.comcast.net/~klight/bzr
Thanks! I've updated the link on the wiki to point at this URL.

I'll keep this bug report open until we've fixed the testsuite to run
on Windows.

Cheers,

Jelmer
--

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Am Dienstag, den 29.01.2008, 01:42 +0000 schrieb Jelmer Vernooij:
> On Mon, Jan 28, 2008 at 01:23:48PM -0000, Kevin Light wrote:
> > Sorry for the delay,
>
> > The bindings: http://home.comcast.net/~klight/bzr/subversion-1.4.6-python-bindings.zip
> > The installer: http://home.comcast.net/~klight/bzr/bzr-svn-0.4.6-svn-1.4.6-setup-0.exe
>
> > I've thrown an index in the folder to help to keep the files visible:
> > http://home.comcast.net/~klight/bzr
> Thanks! I've updated the link on the wiki to point at this URL.
>
> I'll keep this bug report open until we've fixed the testsuite to run
> on Windows.
I've fixed most of the test failures on Windows.

Cheers,

Jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Luke Andrew (luke.andrew) wrote :

The subversion python bindings seem to have disappeared. The link on the wiki (http://d5190871.u44.websitesource.net/bzr/) is ok, but the bindings (http://d5190871.u44.websitesource.net/bzr/subversion-1.4.6-python-bindings.zip) returns a 404. Could we get the files attached to the wiki page? (or at least somewhere a bit more reliable?)

Revision history for this message
Kevin Light (klight) wrote :

----- "Luke Andrew" <email address hidden> wrote:
> The subversion python bindings seem to have disappeared. The link on
> the
> wiki (http://d5190871.u44.websitesource.net/bzr/) is ok, but the
> bindings (http://d5190871.u44.websitesource.net/bzr/subversion-1.4.6
> -python-bindings.zip) returns a 404. Could we get the files attached
> to
> the wiki page? (or at least somewhere a bit more reliable?)

The missing file has been restored. The bzr-svn-0.4.7 release for Win32 can also be found at http://d5190871.u44.websitesource.net/bzr/ .

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I'm inclined to mark this as fix released now that people can use Kevin's installers.

Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.