Mahara

"Search" button is on wrong side in "Default" theme

Bug #1620129 reported by Kristina Hoeppner on 2016-09-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Liam	Mahara 16.10.0

Bug Description

The magnifying glass search button is on the left-hand side in the "Default" theme rather than on the right (see screenshot). The other themes looked correct.

Tags:

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2016-09-04:

search_button.png Edit (11.5 KiB, image/png)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-07: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6936

Liam (liam-sharpe) on 2016-09-07

Changed in mahara:
status:	Confirmed → In Progress
assignee:	nobody → Liam (liam-sharpe)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-09: A change has been merged

Reviewed: https://reviews.mahara.org/6936
Committed: https://git.mahara.org/mahara/mahara/commit/9bc4437082078c52319ab68be3d75616505df257
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9bc4437082078c52319ab68be3d75616505df257
Author: Liam <email address hidden>
Date: Wed Sep 7 15:13:16 2016 +1200

Bug #1620129: Made the search button on the default theme right aligned

Also remove the rounded corners where the button touches the input box

behatnotneeded

Change-Id: Ifdbb54ec779263a45be8654a5dd49a4752d68a1a

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-09: A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/6950

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-09: A change has been merged

Reviewed: https://reviews.mahara.org/6950
Committed: https://git.mahara.org/mahara/mahara/commit/cb61aaff6174107427025f57a2e2d3fc7c539551
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit cb61aaff6174107427025f57a2e2d3fc7c539551
Author: Liam <email address hidden>
Date: Wed Sep 7 15:13:16 2016 +1200

Bug #1620129: Made the search button on the default theme right aligned

Also remove the rounded corners where the button touches the input box

behatnotneeded

Change-Id: Ifdbb54ec779263a45be8654a5dd49a4752d68a1a
(cherry picked from commit 9bc4437082078c52319ab68be3d75616505df257)

Robert Lyon (robertl-9) on 2016-09-09

Changed in mahara:
status:	In Progress → Fix Committed

Robert Lyon (robertl-9) on 2016-09-12

Changed in mahara:
milestone:	16.10rc2 → 16.10.0

Revision history for this message

Robert Lyon (robertl-9) wrote on 2016-09-14:

It turns out it is not fixed if we have the elasticsearch search option enabled

So I'll reopen this bug (seen as it's for 16.10 only and 16.10 is not released yet)

And add a fix for this problem

Changed in mahara:
status:	Fix Committed → In Progress

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-14: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6974

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-14: A change has been merged

Reviewed: https://reviews.mahara.org/6974
Committed: https://git.mahara.org/mahara/mahara/commit/83a2deeefeb62a6be474625cac95f19baa3268e0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 83a2deeefeb62a6be474625cac95f19baa3268e0
Author: Robert Lyon <email address hidden>
Date: Wed Sep 14 12:33:21 2016 +1200

Bug 1620129: Elasticsearch search box wrong on default theme

The header search field is ok when using internal search bout not when
using elasticsearch

behatnotneeded - a layout alignment issue

Change-Id: Ia6e35e3c003a918ce19ce9421a14a6943ba20103
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-14: A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/6975

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2016-09-14: A change has been merged

#10

Reviewed: https://reviews.mahara.org/6975
Committed: https://git.mahara.org/mahara/mahara/commit/b90992fd48c089e25a54377e5bb7d5068da6002a
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit b90992fd48c089e25a54377e5bb7d5068da6002a
Author: Robert Lyon <email address hidden>
Date: Wed Sep 14 12:33:21 2016 +1200

Bug 1620129: Elasticsearch search box wrong on default theme

The header search field is ok when using internal search bout not when
using elasticsearch

behatnotneeded - a layout alignment issue

Change-Id: Ia6e35e3c003a918ce19ce9421a14a6943ba20103
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 83a2deeefeb62a6be474625cac95f19baa3268e0)

Kristina Hoeppner (kris-hoeppner) on 2016-10-12