pqm-submit returns "Connection timed out" error and traceback

Bug #163266 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned
Bazaar PQM Plugin
Invalid
Undecided
Unassigned

Bug Description

When I run pqm-submit, I get:
------------
15:19:39@...> bzr pqm-submit -m "..."
Checking that the public branch is up to date ...
bzr: ERROR: socket.error: (110, 'Connection timed out')

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 802, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 758, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 492, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/pqm/__init__.py", line 88, in run
    submit(b, message=message, dry_run=dry_run, public_location=public_location)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/pqm/pqm_submit.py", line 136, in submit
    smtp.connect(server)
  File "smtplib.py", line 310, in connect
    raise socket.error, msg
error: (110, 'Connection timed out')

bzr 0.92.0.candidate.1 on python 2.5.1.final.0 (linux2)
arguments: ['/usr/bin/bzr', 'pqm-submit', '-m', '...']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_NZ.UTF-8'
plugins:
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [0.92.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  multiparent /usr/lib/python2.5/site-packages/bzrlib/plugins/multiparent.pyc [unknown]
  pqm /usr/lib/python2.5/site-packages/bzrlib/plugins/pqm [unknown]

** Please send this report to <email address hidden>
   with a description of what you were doing when the
   error occurred.
------------
If this is a bug in pqm-submit, please fix it. :-) And if it is not a bug in pqm-submit, it shouldn't return a traceback.

Revision history for this message
James Henstridge (jamesh) wrote :

Do you have smtp_server set in ~/.bazaar/bazaar.conf or ~/.bazaar/locations.conf?

If so, can you connect to that MTA?

If not, do you have a local MTA set up?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

The SMTP server in my bazaar.conf is the same as I successfully use in Thunderbird (I've just checked). smtp_username and smtp_password are also set appropriately. There are no SMTP settings in my locations.conf.

Revision history for this message
James Henstridge (jamesh) wrote :

So it seems that the error here was that Matthew's ISP was dropping port 25 connections, leading to an eventual timeout.

That said, we shouldn't be printing an exception on timeouts -- a proper error should be generated.

While Matthew was using an old version of bzr-pqm, it looks like the bzrlib.smtp_connection code will also fail to catch this error -- it only converts ECONNREFUSED to a BzrError.

Other error values that could easily be triggered by configuration problems include ETIMEDOT, EHOSTUNREACH and ENETUNREACH.

Changed in bzr-pqm:
status: New → Invalid
Martin Pool (mbp)
Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.