Mahara

JS error in Firefox when editing annotation blocks

Bug #1633311 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 17.04.0
16.10
Fix Released
Medium
Unassigned
Mahara 16.10.1
17.04
Fix Released
Medium
Unassigned
Mahara 17.04.0

Bug Description

Version: master (17.04), 16.10
Platform: any
Browser: Firefox (45)

I got the following error when adding/editing an annotation block in a portfolio page.

SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function

It works ok on Chrome 53

Son Nguyen (ngson2000)
Changed in mahara:
status: New → Confirmed
Revision history for this message
Robert Lyon (robertl-9) wrote :

Hi Son,

I'm not able to see this error - is it in the logs, firebug console or elsewhere?

Revision history for this message
Son Nguyen (ngson2000) wrote :

It is in the firebug console. It causes the tinyMCE editor failed to initialize.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7201

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Confirmed → In Progress
importance: Undecided → Medium
milestone: none → 16.10.1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7201
Committed: https://git.mahara.org/mahara/mahara/commit/1102ea404e17da795c49f7ac89814a40b7f10348
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1102ea404e17da795c49f7ac89814a40b7f10348
Author: Son Nguyen <email address hidden>
Date: Fri Oct 21 12:04:26 2016 +1300

Bug 1633311: Fix JS syntax error in strict mode code

behatnotneeded

Change-Id: I63aa142c6c84ea6d71ebb80bb88d51a9e97e2e4b

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7216

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7216
Committed: https://git.mahara.org/mahara/mahara/commit/d59049d671a6114d7af83fb4aca8de58fb5dca24
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit d59049d671a6114d7af83fb4aca8de58fb5dca24
Author: Son Nguyen <email address hidden>
Date: Fri Oct 21 12:04:26 2016 +1300

Bug 1633311: Fix JS syntax error in strict mode code

behatnotneeded

Change-Id: I63aa142c6c84ea6d71ebb80bb88d51a9e97e2e4b
(cherry picked from commit 1102ea404e17da795c49f7ac89814a40b7f10348)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.