Mahara

Ensure dummy admin email is changed on old upgrade

Bug #1639049 reported by Robert Lyon
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 17.04.0

Bug Description

This is similar to https://bugs.launchpad.net/mahara/+bug/1378581 but that only dealt with installing a new site.

If the site was older, say version 1.8 then the incorrect email address would persist in the database.

Need an upgrade snippet to correct this mistake

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.04.0
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7227

Revision history for this message
Robert Lyon (robertl-9) wrote :

Actually we should be checking for any '<email address hidden>' values and updating them as appropriate - as the '<email address hidden>' address should only exist when one installs a new site but hasn't logged in for the first time.

Once they try to log in it prompts them to reset their email address before they can continue.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7227
Committed: https://git.mahara.org/mahara/mahara/commit/a84f17ede7d79f420fed721c1a4277f2e383bd03
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a84f17ede7d79f420fed721c1a4277f2e383bd03
Author: Robert Lyon <email address hidden>
Date: Fri Nov 4 09:57:39 2016 +1300

Bug 1639049: Ensure dummy email is updated in artefact table

For the admin user on a site installed before version 15.04.1

behatnotneeded

Change-Id: I026efdf7e427fabcd75ba725c20f36b07ae50f94
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
David Ligne (david-ligne) wrote :

Hi Robert,
I think you forgot the braces on the table names in htdocs/lib/db/upgrade.php.

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7262

Revision history for this message
Robert Lyon (robertl-9) wrote :

Hi David,

You are correct - I've added another patch https://reviews.mahara.org/#/c/7262/1 to fix up this oversight

Cheers

Robert

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7262
Committed: https://git.mahara.org/mahara/mahara/commit/c88da318712eb4e754d61914cdd450966a6c6550
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c88da318712eb4e754d61914cdd450966a6c6550
Author: Robert Lyon <email address hidden>
Date: Tue Nov 22 09:19:49 2016 +1300

Bug 1639049: Adding the {} to the table names for this upgrade

Oversight on initial patch - should have been picked up in testing

behatnotneeded

Change-Id: I940e1792a2843cda3569a771758a7e98a802a2bf
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.