[SRU] 2.20

Bug #1648520 reported by Michael Vogt
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
snapd (Ubuntu)
Fix Released
Undecided
Unassigned
Trusty
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned
Yakkety
Fix Released
Undecided
Unassigned

Bug Description

This is a new version of snapd.

The changelog for 2.20 is available here https://github.com/snapcore/snapd/blob/2.20/debian/changelog, the raw git changelog is available here: https://github.com/snapcore/snapd/commits/2.20 (note that the debian changelog is auto-generated from the merges of the git commits so there is usually no need to look at the raw git commits).

The snappy team released a new 2.20 release that we want SRU into xenial. The new process described in https://wiki.ubuntu.com/SnapdUpdates was used and we have done integration-tests on the snappy images, autopkgtests on classic and unit tests.

[Test case]
Additionally, verify that the contents of the binary packages have not changed as a result of the package refactoring.

Michael Vogt (mvo)
summary: - [SRU] 2.19
+ [SRU] 2.20
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

Many of the bugs that appear in the generated Launchpad-Bugs-Fixed part of the package do not have Ubuntu tasks, which if they are going to be referenced should. The following are all missing Ubuntu snapd tasks:

bug 1639988
bug 1639967
bug 1638656
bug 1634880
bug 1634089
bug 1624675
bug 1620442

The "SnapdUpdates" process says the following:

"However, individual bugs may be referenced in the from the changelog but each of those bugs will need to independently verified and commented on for the SRU to be considered complete."

Please either square away the bugs by adding Ubuntu tasks and SRU information, or change the formatting of the references to them in the changelog so that they don't end up in Launchpad-Bugs-Fixed.

Changed in snapd (Ubuntu Xenial):
status: New → Incomplete
Revision history for this message
Michael Vogt (mvo) wrote :

I reuploaded the package without bug references now.

Changed in snapd (Ubuntu Xenial):
status: Incomplete → New
Steve Langasek (vorlon)
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in snapd (Ubuntu Trusty):
status: New → Confirmed
Changed in snapd (Ubuntu Xenial):
status: New → Confirmed
Changed in snapd (Ubuntu Yakkety):
status: New → Confirmed
Changed in snapd (Ubuntu):
status: New → Confirmed
Revision history for this message
Steve Langasek (vorlon) wrote :

This SRU bundles snap-confine / ubuntu-core-launcher into the snapd source package. It's not clear that these components are covered by the upstream CI committment in the snapd SRU exception policy; more information is needed to understand how risk of regression is mitigated for these components.

The package merge also means there has been significant (necessary) refactoring of the packaging; test case for this should also include an explicit check that the contents of the binary packages have not changed, or that any changes are known and expected.

Revision history for this message
Steve Langasek (vorlon) wrote :

--- snapd-2.17.1ubuntu1/debian/tests/integrationtests 2016-11-04 16:40:03.000000000 +0000
+++ snapd-2.20ubuntu1/debian/tests/integrationtests 2016-12-15 21:07:08.000000000 +0000
@@ -2,6 +2,14 @@

 set -ex

+if [ "$(dpkg --print-architecture)" = "ppc64el" ]; then
+ echo "Tests on ppc64el disabled for now because autopkgtest thinks they "
+ echo "worked at some point but they did not and noone can override this "
+ echo "in the autopkgtest database apparently so autopkgtest keeps "
+ echo "blocking snapd because it assumes there is a regression."
+ exit 0
+fi
+
 # for these tests, run snap and snapd from outside of the core snap
 mkdir -p /etc/systemd/system/snapd.service.d/
 cat <<EOF | tee /etc/systemd/system/snapd.service.d/no-reexec.conf

That is incorrect. We *can* override this. We do not do so, because ppc64el is a supported server architecture, and snapd is part of our server product, and snapd should not get a blanket exception for test regressions on this architecture.

We will provide exceptions for snapd/ppc64el, upon review, to ensure that the failing tests are not regressions.

But the above change, which disables the autopkgtests on ppc64el altogether and means we get no test results at all, is a non-starter for an SRU, and I am rejecting these packages.

The correct solution here is for the snapd package to be fixed to test the correct things on ppc64el, so that the autopkgtests actually /run and pass/.

In the meantime, I can reupload with this change reverted.

Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package upload rejected

An upload of snapd to xenial-proposed has been rejected from the upload queue for the following reason: "actually disable the ppc64el tests this time.".

Revision history for this message
Steve Langasek (vorlon) wrote :

An upload of snapd to yakkety-proposed has been rejected from the upload queue for the following reason: "actually reinstate the ppc64el tests this time.".

Steve Langasek (vorlon)
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted snapd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.20ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapd (Ubuntu Xenial):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Mark Shuttleworth (sabdfl) wrote : Re: [Bug 1648520] Re: [SRU] 2.20

Thanks very much Steve for moving this through, this should unblock a
good number of snaps.

Mark

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted snapd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.20.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Michael, or anyone else affected,

Accepted snapd into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.20.1+16.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapd (Ubuntu Yakkety):
status: Confirmed → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Michael, or anyone else affected,

Accepted snapd into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.20.1~14.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in snapd (Ubuntu Trusty):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapd - 2.20.1+17.04ubuntu2

---------------
snapd (2.20.1+17.04ubuntu2) zesty; urgency=medium

  * add missing 17.04 autopkgtest targets

 -- Michael Vogt <email address hidden> Wed, 21 Dec 2016 09:54:59 +0100

Changed in snapd (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :

Verifying 2.20.1+16.10 in -proposed for Yakkety, I have confirmed that the following work:

install of offline snap file
install of store snap via commandline
install of store snap via software center
removal of installed snap via commandline
removal of snap via software center

--

snapd was originally version 2.16+16.10ubuntu1.2 on this system before installing the update to 2.20.1+16.10 from -proposed.

Revision history for this message
Andy Whitcroft (apw) wrote :

Hello Michael, or anyone else affected,

Accepted snapd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.20.1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Andy Whitcroft (apw) wrote :

Hello Michael, or anyone else affected,

Accepted snapd into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.20.1+16.10ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Xenial:
The version of snapd 2.20.1ubuntu1 in xenial-proposed has been verified, spread tests and manual tests are successful. The bugs mentioned on the changelog have been fixed and no regression has been identified.

Marking as verification-done

tags: added: verification-done-xenial
tags: added: verification-failed-trusty
tags: removed: verification-failed-trusty
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Yakkety:
The version of snapd 2.20.1+16.10ubuntu2 in yakkety-proposed has been verified, spread tests and manual tests are successful. The bugs mentioned on the changelog have been fixed and no regression has been identified.

Marking as verification-done

tags: added: verification-done-yakkety
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (11.1 KiB)

This bug was fixed in the package snapd - 2.20.1ubuntu1

---------------
snapd (2.20.1ubuntu1) xenial; urgency=medium

  * New upstream release, LP: #1648520
    - generate-packaging-dir: Skip when not running from a git
      checkout. This fixes an autopkgtest failure.

snapd (2.20.1) xenial; urgency=medium

  * New upstream release, LP: #1648520
    - tests: enable the ppc64el tests again
    - tests: add classic confinement test
    - tests: run snap confine tests in debian/rules already

snapd (2.20) xenial; urgency=medium

  * New upstream release, LP: #1648520
    - many: implement "snap alias --reset" using snapstate.ResetAliases
    - debian: use a packaging branch for 14.04
    - store: retry downloads on io.Copy errors and sha3 checksum errors
    - snap: show apps in `snap info`
    - store: send an explicit X-Ubuntu-Classic header to the store
    - overlord/snapstate: implement snapstate.ResetAliases
    - interfaces/builtin: add dbus interface
    - tests: fix tests on 17.04
    - store: use mocked retry strategy to make store tests faster
    - overlord: apply auto-aliases information from the snap-declaration
      on install or refresh
    - many: prepare landing on trusty
    - many: implement snap unalias using snapstate.Unalias
    - overlord/snapstate: fixing the placement/grouping of some
      functions
    - interfaces: support network namespaces via 'ip netns' in network-
      control
    - interfaces/builtin: fix pulseaudio apparmor rules
    - interfaces/builtin: add iio interface
    - tests: update custom core snap with the freshly build snap-confine
    - interfaces: use sysd.{Disable,Stop} instead of sysd.DisableNow()
    - overlord,overlord/snapstate: implement snapstate.Unalias by
      generalizing the "alias" task
    - interfaces: misc openstack snap enablement
    - cmd/snap: mock terminal.ReadPassword instead of using /dev/ptmx
    - notifications, daemon: kill the unsupported events endpoint
    - client: only allow Dangerous option in InstallPath
    - overlord/ifacestate: no interface checks if no snap id
    - many: implement alias command
    - snap: tweak snap install output as designed by Mark
    - debian: fix Pre-Depends on dpkg
    - tests: check if snap-confine --version is unknown
    - cmd/snap-confine: allow content interface mounts
    - tests: remove ppa:snappy-dev/image again
    - interfaces/apparmor: allow access to core snap
    - tests: remove snap-confine/ubuntu-core-launcher after the tests
    - overlord,overlord/snapstate: implement snapstate.Alias
    - cmd/snap: reject "snap disconnect foo"
    - debian: add split ubuntu-core-launcher and snap-confine packages
    - cmd: fix mkversion.sh and add regression test
    - overlord/snapstate: setup/remove aliases as we link/unlink snaps
    - cmd/snap,tests: alias support in snap run
    - snap/snapenv: don't obscure HOME if snap uses classic confinement
    - store: decode response.Body json inside retry loops
    - cmd/snap-confine: fix compilation on platforms with gcc < 4.9.0
    - vendor: update tomb package fixing context support

snapd (2.19) xenial; urgency=medium

  * New upstream release, LP: #1648520
    - cmd/snap-confi...

Changed in snapd (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapd - 2.20.1+16.10ubuntu2

---------------
snapd (2.20.1+16.10ubuntu2) yakkety; urgency=medium

  * New upstream release, LP: #1648520
    - spread.yaml: update for ppc64el, i386, armhf

 -- Michael Vogt <email address hidden> Tue, 03 Jan 2017 22:16:08 +0100

Changed in snapd (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Andy Whitcroft (apw) wrote :

Hello Michael, or anyone else affected,

Accepted snapd into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd/2.21~14.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Rolf Leggewie (r0lf) wrote :

This is superseded by bug 1656382

Revision history for this message
Mathew Hodson (mhodson) wrote :

This shouldn't be a duplicate. It was used to release 2.20, and it is included in the changelog for Xenial and Yakkety.

I closed the Trusty task, since the work has moved to 2.21 in bug #1656382.

Changed in snapd (Ubuntu Trusty):
status: Fix Committed → Won't Fix
tags: removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.3 KiB)

This bug was fixed in the package snapd - 2.21~14.04.2

---------------
snapd (2.21~14.04.2) trusty; urgency=medium

  * New upstream release, LP: #1656382:
    - trusty backport
    - remove debian/tests/control golang-golang-x-net-dev dependency
      to make autopkgtests work

snapd (2.21~14.04.1) trusty; urgency=medium

  * New upstream release, LP: #1656382:
    - trusty backport

snapd (2.21) xenial; urgency=medium

  * New upstream release, LP: #1656382
    - daemon: re-enable reexec
    - interfaces: allow reading installed files from previous revisions
      by default
    - daemon: make activation optional
    - tests: run all snap-confine tests in c-unit-tests task
    - many: fix abbreviated forms of disconnect
    - tests: switch more tests to MATCH
    - store: export userAgent. daemon: print store.UserAgent() on
      startup.
    - tests: test classic confinement `snap list` and `snap info`
      output
    - debian: skip snap-confine unit tests on nocheck
    - overlord/snapstate: share code between Update and UpdateMany, so
      that it deals with auto-aliases correctly
    - interfaces: upower-observe: refactor to allow snaps to provide a
      slot
    - tests: add end-to-end store test for classic confinement
    - overlord,overlord/snapstate: have UpdateMany retire/enable auto-
      aliases even without new revision
    - interfaces/browser-support: add @{PROC}/@{pid}/fd/[0-9] w and misc
      /run/udev
    - interfaces/builtin: add physical-memory-* and io-ports-control
    - interfaces: allow getsockopt by default since it is so commonly
      used
    - cmd/snap, daemon, overlord/snapstate: tests and fixes for "snap
      refresh" of a classic snap
    - interfaces: allow read/write access of real-time clock with time-
      control interface
    - store: request no CDN via a header using SNAPPY_STORE_NO_CDN
      envvar
    - snap: add information about tracking channel (not just actual
      channel)
    - interfaces: use fewer dot imports
    - overlord/snapstate: remove restrictions on ResetAliases
    - overlord, store: move confinement filtering to the overlord (from
      The Store)
    - many: move interface test helpers to ifacetest package
    - many: implement 'snap aliases'
    - vet: fix for unkeyed fields error on aliases_test.go
    - interfaces: miscellaneous policy updates for network-control,
      unity7, pulseaudio, default and home
    - tests: test for auto-aliases
    - interface hooks: connect plug slot hooks (step 2)
    - cmd/snap: fix internal naming in snap connect
    - snap: use "size" as the json tag in snap.ChannelSnapInfo
    - tests: restore the missing initialization of iface manager causing
      race
    - snap: fix missing sizes in `snap info <remote-snap>`
    - tests: improve cleanup for c-unit-tests
    - cmd/snap-confine: build non-installed libsnap-confine-private.a
    - cmd/snap-confine: small tweaks to seccomp support code
    - interfaces/docker-support: allow /run/shm/aufs.xeno for 14.04
    - many: obtain installed snaps developer/publisher username through
      assertions
    - store: setting of fields for details endpoint
    - cmd/snap-confine: check for rst2man ...

Read more...

Changed in snapd (Ubuntu Trusty):
status: Won't Fix → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for snapd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.