Mahara

Navigating to fonts in admin throws an error

Bug #1651592 reported by Niranjan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned
Mahara 17.10.0
17.04
Fix Released
Low
Unassigned
Mahara 17.04.2
17.10
Fix Released
Low
Unassigned
Mahara 17.10.0

Bug Description

Version: 17:04
Browser: Chrome, FF

Steps to Reproduce:

1) Login as admin
2) Navigate to Administration> configure site> fonts

Result: Warning message is displayed as below but if the config file has $cfg->skins = true; it doesnt throw an error and if set to false it throws the same error.

[WAR] 39 (admin/site/fonts.php:25)

Call stack (most recent first):
log_message("", 8, true, true, "/home/niranjanbandi/code/mahara/htdocs/admin/site/...", 25, array(size 0)) at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:648
MaharaException->handle_exception() at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:547
exception(object(FeatureNotEnabledException)) at Unknown:0

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Classed as "Medium" and not for backports because there is an easy work-around (set skins to true) and institutions can still decide whether to use skins or not.

Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 17.04.0
Revision history for this message
Robert Lyon (robertl-9) wrote :

Hmm, actually the error that it is throwing is correct:

 exception(object(FeatureNotEnabledException))

It is saying the feature is not enabled.

What we need to do is catch the error and throw an 'access denied' type error to give the 'You do not have permission to see this page' screen.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 17.04.0 → 17.04.1
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7747

Revision history for this message
Robert Lyon (robertl-9) wrote :

This is actually only an issue if we turn skins off and do not remake the navigation by clearing cache

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7747
Committed: https://git.mahara.org/mahara/mahara/commit/bba4789acaf16df78684d1a0c6ca9f1135a4a8ea
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bba4789acaf16df78684d1a0c6ca9f1135a4a8ea
Author: Robert Lyon <email address hidden>
Date: Thu May 11 19:31:04 2017 +1200

Bug 1651592: Changing the error thrown if skins not enabled

When navigating to the admin/site/fonts.php page.

behatnotneeded

Change-Id: Id627b582b3a30598900ba3a7e9b486579a65d0f6
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7778

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7778
Committed: https://git.mahara.org/mahara/mahara/commit/497bbc836914d8a4a0552bd95a94d0c36ddf91a8
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 497bbc836914d8a4a0552bd95a94d0c36ddf91a8
Author: Robert Lyon <email address hidden>
Date: Thu May 11 19:31:04 2017 +1200

Bug 1651592: Changing the error thrown if skins not enabled

When navigating to the admin/site/fonts.php page.

behatnotneeded

Change-Id: Id627b582b3a30598900ba3a7e9b486579a65d0f6
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit bba4789acaf16df78684d1a0c6ca9f1135a4a8ea)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.