Ubuntu
libvirt package

virsh nodecpumap --pretty shows unwanted cpu map output

Bug #1659769 reported by bugproxy
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvirt (Ubuntu)
Fix Released
Medium
Taco Screen team
Xenial
Fix Released
Medium
Unassigned

Bug Description

[Impact]

 * virsh nodecpumap --pretty --pretty shows wrong result on machine with
   many cores

 * Since admin and scripts might rely on those they should be fixed.
   Not only are they not nice, they are depending on the case even wrong
   sometimes.

 * an example is like:
   virsh nodecpumap --pretty
   CPUs present: 120
   CPUs online: 120
   CPU map: 0-119,192,196,199,258,262,264,267,269-270,272-273,276-278,284-286,290-291,293-294,296,301-302,304,307-310,314,316,318,320,322,325-326,331-334,338,340-342,802-803,805,807-809,813-814,816-818,821-822,825,828-829,831,833,836

[Test Case]

 * Go to a huge machine with many CPUs (a virtual machine with faked vcpus
   might help, but stay aware of issues with 2nd level virtualization)

 * run "virsh nodecpumap --pretty"

 * Tests with extra splits into numa nodes can be done, but are not
   necessary to show the effect

[Regression Potential]

 * Fix is upstream quite while now without further changes which should make it safe.

 * Also since the code is restricted to "virsh nodecpumap" and not reused
   any potential regression should be limited to that sub-command which is
   nice for some use-cases but not a core function in general.

[Other Info]

 * n/a

----- original report ------

Please cherry pick this issue.

https://bugzilla.redhat.com/show_bug.cgi?id=1329819

commit 3a703b8120d9f996840bd315b6f74c45a7e98aad

See original description
Revision history for this message
bugproxy (bugproxy) wrote : virsh-nodecpumap-pretty-shows-wrong-results-on-machine

Default Comment by Bridge

tags: added: architecture-ppc64le bugnameltc-150505 severity-high targetmilestone-inin16042
Changed in ubuntu:
assignee: nobody → Taco Screen team (taco-screen-team)
affects: ubuntu → libvirt (Ubuntu)
Jon Grimm (jgrimm)
Changed in libvirt (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
to confirm that is patch "virsh: host: Use bitmap size in bytes rather than bit count" right?

Assuming that I'm setting all >=Yakkety to fix Released as that was in anything >= v1.3.4

Am I correct that you hereby requested a Xenial SRU for this fix?

Changed in libvirt (Ubuntu Xenial):
status: New → Confirmed
importance: Undecided → Medium
Changed in libvirt (Ubuntu):
status: Triaged → Fix Released
Christian Ehrhardt  (paelzer)
description: updated
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2017-02-07 06:57 EDT-------
Making Seeteena comment public.

--------------------------------

(In reply to comment #12)
> Hi,
> to confirm that is patch "virsh: host: Use bitmap size in bytes rather than
> bit count" right?

Yes. correct.

>
> Assuming that I'm setting all >=Yakkety to fix Released as that was in
> anything >= v1.3.4
>
> Am I correct that you hereby requested a Xenial SRU for this fix?

Yes. right. These fix needs to be incorpoated to 16.04.02 as well.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Working on the SRU already since a few days ago, but I think 16.04.02 is out of reach.
IIRC we are frozen in that regard already - aren't we - need to check the details?

Anyway - working on it already and we will see.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

On ppa identical to SRU upload:
- Automated Tests passed (to check for regressions)
- Manual Test passed (to check for regressions)
- Explicit tests on this case worked

Uploaded to SRU queue now for SRU Team to check.

Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello bugproxy, or anyone else affected,

Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libvirt (Ubuntu Xenial):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Before (1.3.1-1ubuntu10.7):
ubuntu@diamond:~$ virsh nodecpumap --pretty
CPUs present: 160
CPUs online: 20
CPU map: 0,8,16,24,32,40,48,56,64,72,80,88,96,104,112,120,128,136,144,152,192,196-197,199,833,902-904,906-909,913-915,918,921-922,924-925,936,964,1029,1034-1037,1041-1043,1046,1049-1050,1052-1053,1064,1221,1226-1229,1233-1235,1238,1241-1242,1244-1245,1256

After (1.3.1-1ubuntu10.8):
ubuntu@diamond:~$ virsh nodecpumap --pretty
CPUs present: 160
CPUs online: 20
CPU map: 0,8,16,24,32,40,48,56,64,72,80,88,96,104,112,120,128,136,144,152

tags: added: verification-done
removed: verification-needed
Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2017-02-15 01:18 EDT-------
Tested and found working on
libvirt-bin 1.3.1-1ubuntu10.8 ppc64el programs for the libvirt library

# virsh nodecpumap --pretty
CPUs present: 192
CPUs online: 24
CPU map: 0,8,16,24,32,40,48,56,64,72,80,88,96,104,112,120,128,136,144,152,160,168,176,184

------- Comment From <email address hidden> 2017-02-15 01:19 EDT-------
Closing as per previous comment.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvirt - 1.3.1-1ubuntu10.8

---------------
libvirt (1.3.1-1ubuntu10.8) xenial; urgency=medium

  * fix virsh nodecpumap output (LP: #1659769)
  * fix using type ethernet interfaces with user scripts (LP: #1620407)
  * add new block device types to virt-aa-helpers profile (LP: #1641618)

 -- Christian Ehrhardt <email address hidden> Mon, 06 Feb 2017 14:30:46 +0100

Changed in libvirt (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for libvirt has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.