[Intel feature] Include latest version of Enclosure LED Utilities

Currently feature submit has been freezed on Feb, 18 for Ubuntu 17.04. The target version is defined to Ubuntu 17.10. If there is any emergency request, please input the comment here, and we will have a discussion with Canonical to make sure if we can make it happen in 17.04.

Thanks

https://sourceforge.net/p/ledmon/code/ci/ledmon-0.80/tree/

it is the latest version.

It appears the current version of ledmon in Ubuntu is 0.79. I've added a task for ledmon to request an update to version 0.80 for the 17.10 release.

Ubuntu's ledmon is synced from Debian, and Debian's latest version is still 0.79.
I have filed a bug at bugs.debian.org for an update of the package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878271.

lemon target is 1.0 (Planned upstream WW08)

Hi Anthony, is there any update on the Debian side? As of today, Bionic still has 0.79, as does Debian, it appears, though that pkgwatch link shows 0.80 available.

Hi,
We recently moved from sourceforge to github:
https://github.com/intel/ledmon

Also like Pragyan said,
We are going to release ledmon 0.90 (it's to early for 1.0 yet :) ) with new functionality, and we would like this one to be included in ubuntu 18.04. It is trending to be released late February (ww8).

Thanks
Pawel

@jeff
No further update from debian maintainer since his last reply in debian bug. As Intel is going to releae 0.90 I think we can skip 0.80 and shoot for 0.90.

Hi,
ledmon-v0.90 is now available on our github:
https://github.com/intel/ledmon/releases/tag/v0.90
Please include it in Ubuntu 18.04

Thanks
Pawel

@Anthony,

I was looking at the Debian watch page, and they're still looking at Sourceforge for Ledmon upstream changes. They need to start watching github instead, as the SF page indicates:

"Project has been moved to github - https://github.com/intel/ledmon"

Also, as Pawel mentions, 0.90 was released a few days ago.

Debian has not updated, and we're now passed Debian Import Freeze. Bionic likely will remain with version 0.79.

This seems to not be critical to VROC as far as I understand it just blinks some lights to indicate VROC I/O. This is a good candidate for providing as a Snap via the Snap Store which allows for updates outside of the normal Ubuntu dev schedule.

Otherwise, deferring to 18.10

Ledmon functionality is not indicating the I/O.
It is indicating the state of VROC RAID arrays (failure, rebuild, locate).
This is very important feature for VROC users.
Please include ledmon v0.90 in 18.04 LTS.

Thanks
Pawel

So there are two options here, currently:

You can create a snap and distribute it as a snap package and not have to pay any attention to the Ubuntu dev cycle and freeze dates, you can release whenever you want to, whatever versions you want to regardless of where we are in the development cycle.

OR

You can pressure the Debian maintainer to update and I can try to request a freeze exception to get this version from Debian.

Here is the problem we're facing.

ledmon already exists in Ubuntu, but it's pulled from Debian.

Currently, ledmon in Debian is version 0.79.

Please refer to the upstream Debian bug here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878271

In October, we filed the bug asking to update ledmon in Debian to 0.80 once it was available.

The debian maintainer said he could do it, and we offered to help testing (thought for VROC, we'd need Intel to do the testing).

The Debian maintainer then went silent and nothing further happened. In feburary, we advised the debian maintainer that 1: ledmon 0.90 was now out and he should update to that version instead of 0.80. We also informed him that debian is watching the wrong (Older) source location for updates to ledmon. We provided the new GitHub upstream location.

The Debian maintainer has not responded to this. The package watch is still looking at the old Source Forge location.

I will ask around internally as well, but ultimately there is likely not much that can be done for Bionic outside of my suggestions above.

Hi,
I also pinged maintainer from debian on their mailing list.
Still no replay...
Is this "debian first" rule applies to all packages of ubuntu?
I'm asking, because we have other components (for example - mdadm: https://bugs.launchpad.net/bugs/1751771) that are requested to be integrated to Ubuntu 18.04.

Thanks
Pawel

Status changed to 'Confirmed' because the bug affects multiple users.

Hi,

OK, I'm working on the FFE. The first part of that is to have a working and tested package ready.

To that end, I've built 0.90 in my testbuilds ppa, can you please test this out on bionic and ensure that the package installs and works as it should?

To install:

sudo add-apt-repository ppa:bladernr/testbuilds
sudo apt update
sudo apt install ledmon

I only built it for Bionic, so you'll need to install to that environment.

Please test and let me know if all is well and I'll proceed with filing the FFE bug.

Hello Jeff!

We run test on ledmon provided by you. We found two issues related with ubuntu environment. Both of them are fixed by me in upstream (github repo, master branch - https://github.com/intel/ledmon/commits/master).

Can you also pick those two patches to ubuntu ledmon?
https://github.com/intel/ledmon/commit/c57e7d6d2dabe9e9d17d2e3aa4a2e77f7dc70acd
https://github.com/intel/ledmon/commit/26af13fd4d784ce7cf6ecbdd7cc154bf157ac7af

Regards,
Michal

Done, I think. there's a new packate 0.90-1.4 in the testbuilds ppa now. see if that works for you.

I think something goes wrong. On ledmon 0.90-1.4 both of previously founded issues are still reproducible.

I downloaded sources via apt-get source ledmon. After tar -zxvf ledmon_0.90.orig.tar.gz, I checked code for my changes and I think both of the patches are not applied.

I check installed version via dpkg to be sure:
dpkg -s ledmon
Package: ledmon
Status: install ok installed
Priority: optional
Section: admin
Installed-Size: 191
Maintainer: Daniel Jared Dominguez <email address hidden>
Architecture: amd64
Version: 0.90-1.4
Depends: libc6 (>= 2.14), libsgutils2-2 (>= 1.27), libudev1 (>= 183), openipmi
Description: Enclosure LED Utilities
 ledmon and ledctl are userspace tools designed to control storage
 enclosure LEDs. The user must have root privileges to use these tools.
 .
 These tools use the SGPIO and SES-2 protocols to monitor and control LEDs.
 They been verified to work with Intel(R) storage controllers (i.e. the
 Intel(R) AHCI controller) and have not been tested with storage controllers of
 other vendors (especially SAS/SCSI controllers).
 .
 For backplane enclosures attached to ISCI controllers, support is limited to
 Intel(R) Intelligent Backplanes.
Homepage: http://ledmon.sourceforge.net/

It's 0.90-1.4, so it is fine.

Also,
If I can give small suggestion. Can you change Homepage link to github ledmon? ( https://github.com/intel/ledmon ). Shortly we stop pushing anything to Sourceforge.

apologies. I've somehow screwed up the ppa.

So I've created a new one and have newly built packages of ledmon there now.

Please try this ppa:

ppa:~bladernr/ledmon

and you should now get a package versioned at 0.90-1.6.

I based this on the current trunk at github, which should include the fixes you requested, and rebuilt the source to match for the new ppa mentioned above.

Sorry, but I can't make your ppa working for me on my ubuntu installation.
I still get:
E: Failed to fetch http://ppa.launchpad.net/bladernr/ledmon/ubuntu/dists/bionic/main/binary-amd64/Packages 404 Not Found
during apt-get update and ledmon is no available to install.
When I tried with '~' in apt-get update I have:
E: Failed to fetch http://ppa.launchpad.net/~bladernr/ledmon/ubuntu/dists/bionic/main/binary-i386/Packages 403 Forbidden

So, I just downloaded deb via http://ppa.launchpad.net/bladernr/ledmon/ubuntu/pool/main/l/ledmon/ledmon_0.90-1.6_amd64.deb
After installation:
dpkg -i ledmon_0.90-1.6_amd64.deb
I still can reproduce two issues fixes by my additional patches.
So I downloaded http://ppa.launchpad.net/bladernr/ledmon/ubuntu/pool/main/l/ledmon/ledmon_0.90.orig.tar.gz. After unpacking I don't see my fixes for example in src/pidfile.c.

In git log I see merge commit for my patches (c0561c2f930c38716e981b2ef15133e4c40fe5bc). But the next commit (4fba45588380c302ae8e7d4c3f10ea8d6d72a526) removes (reverts) previous merge:

git show 4fba45588380c302ae8e7d4c3f10ea8d6d72a526
commit 4fba45588380c302ae8e7d4c3f10ea8d6d72a526
Author: Jeff Lane <email address hidden>
Date: Wed Mar 28 15:20:12 2018 -0400

    bump for ppa and add upstream patches

diff --git a/debian/changelog b/debian/changelog
index c595505..ebd031c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+ledmon (0.90-1.4) bionic; urgency=medium
+
+ * bump for PPA
+
+ -- Jeff Lane <email address hidden> Wed, 28 Mar 2018 15:15:06 -0400
+
 ledmon (0.90-1.3) bionic; urgency=medium

   * pulled in upstream patches and bump rev for new build
diff --git a/src/pidfile.c b/src/pidfile.c
index 0f6ff4d..49fd1df 100644
--- a/src/pidfile.c
+++ b/src/pidfile.c
@@ -20,7 +20,6 @@
 #include <errno.h>
 #include <fcntl.h>
 #include <limits.h>
-#include <signal.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -82,9 +81,9 @@ int pidfile_remove(const char *name)
  */
 int ping_proc(pid_t pid)
 {
- if (pid <= 0)
- return STATUS_INVALID_PATH;
- if (kill(pid, 1) == 0)
+ char buf[PATH_MAX];
+ sprintf(buf, "kill -n 10 %d 2>/dev/null", pid);
+ if (system(buf) == 0)
                return STATUS_SUCCESS;
        return STATUS_INVALID_PATH;
 }
diff --git a/src/sysfs.c b/src/sysfs.c
index f42be09..1a18a8b 100644
--- a/src/sysfs.c
+++ b/src/sysfs.c
@@ -125,7 +125,7 @@ static enum device_type _get_device_type(const char *path)
        if (p != NULL) {
                if (strlen(p) > 0) {
                        if (strncmp(p, "external:", 9) == 0) {
- if (p[9] == '/' || p[9] == '-')
+ if (p[9] == '/')
                                        result = DEVICE_TYPE_VOLUME;
                                else
                                        result = DEVICE_TYPE_CONTAINER;

So I think something went wrong again during merging.

Yeah, I have no idea what I messed up there. So one more try. There should now be 0.90-1.7 in my ppa, built for bionic:

ppa:~bladernr/ledmon

I'm not sure how I ended up reverting those patches, but they should be there now.
Also, just to be sure, I'll get you to check out the final package (which will be a rebuild from scratch to clean up the git and debian logs).

Hi, I updated the bug last week, I'm not sure how I ended up reverting
those changes, but the current version in the test PPA should work,
here's the diff from that latest upload:

diff -Nru ledmon-0.90/debian/changelog ledmon-0.90/debian/changelog
--- ledmon-0.90/debian/changelog 2018-03-29 15:48:25.000000000 +0000
+++ ledmon-0.90/debian/changelog 2018-03-30 18:10:46.000000000 +0000
@@ -1,3 +1,9 @@
+ledmon (0.90-1.7) bionic; urgency=medium
+
+ * reverted previous commit that somehow removed necessary patches
+
+ -- Jeff Lane <email address hidden> Fri, 30 Mar 2018 14:10:05 -0400
+
 ledmon (0.90-1.6) xenial; urgency=medium

   * fixed homepage and source location data in packaging info
diff -Nru ledmon-0.90/debian/patches/series ledmon-0.90/debian/patches/series
--- ledmon-0.90/debian/patches/series 1970-01-01 00:00:00.000000000 +0000
+++ ledmon-0.90/debian/patches/series 2018-03-30 18:13:21.000000000 +0000
@@ -0,0 +1 @@
+upstream-fixes
diff -Nru ledmon-0.90/debian/patches/upstream-fixes
ledmon-0.90/debian/patches/upstream-fixes
--- ledmon-0.90/debian/patches/upstream-fixes 1970-01-01
00:00:00.000000000 +0000
+++ ledmon-0.90/debian/patches/upstream-fixes 2018-03-30
18:15:48.000000000 +0000
@@ -0,0 +1,55 @@
+Description: upstream fixes pulled in for FFE
+ Reapply upstream patches
+ .
+ ledmon (0.90-1.7) bionic; urgency=medium
+ .
+ * reverted previous commit that somehow removed necessary patches
+Author: Jeff Lane <email address hidden>
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: https://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: <YYYY-MM-DD>
+
+--- ledmon-0.90.orig/src/pidfile.c
++++ ledmon-0.90/src/pidfile.c
+@@ -20,6 +20,7 @@
+ #include <errno.h>
+ #include <fcntl.h>
+ #include <limits.h>
++#include <signal.h>
+ #include <stdint.h>
+ #include <stdio.h>
+ #include <stdlib.h>
+@@ -81,9 +82,9 @@ int pidfile_remove(const char *name)
+ */
+ int ping_proc(pid_t pid)
+ {
+- char buf[PATH_MAX];
+- sprintf(buf, "kill -n 10 %d 2>/dev/null", pid);
+- if (system(buf) == 0)
++ if (pid <= 0)
++ return STATUS_INVALID_PATH;
++ if (kill(pid, 1) == 0)
+ return STATUS_SUCCESS;
+ return STATUS_INVALID_PATH;
+ }
+--- ledmon-0.90.orig/src/sysfs.c
++++ ledmon-0.90/src/sysfs.c
+@@ -125,7 +125,7 @@ static enum device_type _get_device_type
+ if (p != NULL) {
+ if (strlen(p) > 0) {
+ if (strncmp(p, "external:", 9) == 0) {
+- if (p[9] == '/')
++ if (p[9] == '/' || p[9] == '-')
+ result = DEVICE_TYPE_VOLUME;
+ else
+ result = DEVICE_TYPE_CONTAINER;

On Fri, Mar 30, 2018 at 6:19 AM, Michał Żyłowski
<email address hidden> wrote:
> Sorry, but I can't make your ppa working for me on my ubuntu installation.
> I still get:
> E: Failed to fetch http://ppa.launchpad.net/bladernr/ledmon/ubuntu/dists/bionic/main/bi...

Sorry for late answer, there was few days off because of holidays in Poland.

Everything looks good. No issues with ledmon_0.90-1.7_amd64.deb.

Thanks for your work!

Great! I’ll start the FFE paperwork today then. And rebuild a clean package
as a final build.

On Tue, Apr 3, 2018 at 06:21 Michał Żyłowski <email address hidden>
wrote:

> Sorry for late answer, there was few days off because of holidays in
> Poland.
>
> Everything looks good. No issues with ledmon_0.90-1.7_amd64.deb.
>
> Thanks for your work!
>
> --
> You received this bug notification because you are a member of Intel
> Team, which is subscribed to intel.
> Matching subscriptions: Private or proprietary bugs
> https://bugs.launchpad.net/bugs/1668126
>
> Title:
> [Intel feature] Include latest version of Enclosure LED Utilities
>
> Status in intel:
> In Progress
> Status in ledmon package in Ubuntu:
> Confirmed
>
> Bug description:
> Feature Description:
> Include Latest version of Enclosure LED Utilities
>
> The LEDCTL and LEDMON applications are design to work on both AHCI and
> SCU.
> Both use broad range of protocols to control LEDs e.g. SGPIO, SES-2,
> SGPIO over SMP, etc.
> Also, new version of ledmon adds the functionality of blinking LED with
> NVMe under VMD domains.
> The LEDCTL application is similar to SGPIO but the major difference is
> that LEDCTL (as well as LEDMON) has the internal logic built in and this
> means it is aware about RAID devices present in the system.
> Enable LED management for software RAID solutions.
>
> The ledctl is user space application design to control LEDs associated
> with each slot in an enclosure or a drive bay. There are two types of
> system: 2-LEDs system (Activity LED, Status LED) and 3-LEDs system
> (Activity LED, Locate LED, Fail LED). User must have root privileges to use
> this application.
> The ledctl application uses SGPIO and SES-2 protocol to control LEDs.
> The program implements IBPI patterns from SFF-8489 specification for
> SGPIO.
> New version on ledmon will contain new feature:
> - led blinking functionality for NVMe drives under VMD domains.
> - bugfixes
>
> The ledmon application is daemon program to monitor a state of
> software RAID device (md only) or a state of block device. The state
> is visualizing on LEDs associated with each slot in an enclosure or a
> drive bay. There are two types of system: 2-LEDs system (Activity LED,
> Status LED) and 3-LEDs system (Activity LED, Locate LED, Fail LED).
> This application has the highest priority when accessing the LEDs.
>
> External links:
> http://ledmon.sourceforge.net
> http://sourceforge.net/projects/ledmon/files/
> Ledmon application is in active development.
> Final version will be available at:
> http://ledmon.sourceforge.net
>
> Target Release: 18.04
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/intel/+bug/1668126/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: product=intel; status=In Progress; importance=High;
> <email address hidden>;
> Launchpad-Bug: distribution=ubuntu; sourcepackage=ledmon;
> component=universe; status=Confirmed; importance=Undecided; assignee=None;
> Launchpad-Bug-Tags: user-space-pkgs
> Launchpad-Bug-Information-Type: Private
> Launchpad-Bug-Private: yes
> Launchpad-B...

Hi Michal,

One last final check, could you test this ppa:

ppa:bladernr/final-builds

https://launchpad.net/~bladernr/+archive/ubuntu/final-builds/+packages

and try ledmon (it's now back to 0.90-1). This is the package I plan to push through the FFE process and hopefully upload to Ubuntu, so I'd appreciate a final check. It is basically just a fresh respin of the source tarball and patches you added to 0.90.

Also, FFE bug filed.

https://bugs.launchpad.net/ubuntu/+bug/1760937

Hello!

No issues with ledmon from final-builds ppa (0.90-1).

Thanks!

Hello!
What is the status here?

Is there any chance ledmon v0.90 will be available in ubuntu 18.04.1?

Can we move this bug to the "Linux" package and make it public?

ledmon (0.90-0ubuntu1) cosmic; urgency=medium

  * New upstream release
  * Drop upstream cherrypick
  * Refresh patches
  * Bump standards version

 -- Dimitri John Ledkov <email address hidden> Wed, 01 Aug 2018 10:59:20 +0100

is in cosmic now.

@jsalisbury this bug is about a userspace package i thought, without any linux component to it...

@intel - I see there are further upstream commits post v0.90 should I cherrypick those? or are they not essential / minor / to be released later? See the list of commits at https://github.com/intel/ledmon/compare/v0.90...master

yes, can be public. Thanks

Hello Dimitri!

We tested deb created by you. There is a problem with blinking during migration. This issue is solved by commit https://github.com/intel/ledmon/commit/c57e7d6d2dabe9e9d17d2e3aa4a2e77f7dc70acd

Also there is few other minor issues. All of them can be resolved applying this list of patches:
https://github.com/intel/ledmon/compare/v0.90...1616efa

I will be grateful if you can still do it.

@Dimitri, are we ready to start the SRU process to Bionic for ledmon (0.90-0ubuntu1)? Or we need to wait for the suggested patches (as in comment#34) to be ready? By the way, te SRU request is recorded at https://bugs.launchpad.net/ubuntu/+source/ledmon/+bug/1789786

Hi Intel,

The ledmon SRU into bionic is just landed into -proposed:
https://bugs.launchpad.net/ubuntu/+source/ledmon/+bug/1789786/comments/8

However, I noticed that comment #34 provided several patches for fixing some issues, I'm not sure if Dimitri will take a look, but I can do that if available.

Woodrow