OpenStack Dashboard (Horizon)

A inappropriate message after live migrate failed.

Bug #1684394 reported by Debo Zhang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Debo Zhang
OpenStack Dashboard (Horizon) pike-2

Bug Description

If live migrate operation failed, there would be a message like:

"Failed to live migrate instance to host "host01"."

But, if we choose none target host, the message will be:

"Failed to live migrate instance to host ""."

The empty quotes looks strange.

Debo Zhang (laun-zhangdebo)
Changed in horizon:
assignee: nobody → Debo Zhang (laun-zhangdebo)
status: New → In Progress
Revision history for this message
Debo Zhang (laun-zhangdebo) wrote :

Please review https://review.openstack.org/#/c/458346/

Changed in horizon:
status: In Progress → Fix Committed
Debo Zhang (laun-zhangdebo)
Changed in horizon:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Debo Zhang (<email address hidden>) on branch: master
Review: https://review.openstack.org/458346

Revision history for this message
Debo Zhang (laun-zhangdebo) wrote :

Please review
https://review.openstack.org/#/c/458374/

Akihiro Motoki (amotoki)
Changed in horizon:
importance: Undecided → Low
milestone: none → pike-2
OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: Debo Zhang (laun-zhangdebo) → Akihiro Motoki (amotoki)
Akihiro Motoki (amotoki)
Changed in horizon:
assignee: Akihiro Motoki (amotoki) → Debo Zhang (laun-zhangdebo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/458374
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e7a082d0a280706d3a4523b0bab727d6adf76a97
Submitter: Jenkins
Branch: master

commit e7a082d0a280706d3a4523b0bab727d6adf76a97
Author: zhangdebo <email address hidden>
Date: Thu Apr 20 00:45:35 2017 -0700

    Fix a message bug after a failing live migrate

    If live migrate operation failed, there would be a message like:
    'Failed to live migrate instance to host "host01".'
    But, if we choose none target host, the message will be:
    'Failed to live migrate instance to host "".'
    The empty quote marks looks strange.

    I think it would be better to check whether data['host'] is
    None/empty at first and use a message without hostname if it is.

    Change-Id: Ib25f2d9481cfe9a5119d3473ba7ea8032720f45a
    Closes-Bug: #1684394

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b2

This issue was fixed in the openstack/horizon 12.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.