Ubuntu
ubuntu-release-upgrader package

upgrade from Zesty to Artful fails if done in text mode

Bug #1686117 reported by Brian Murray
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
screen (Ubuntu)
Invalid
Undecided
Unassigned
ubuntu-release-upgrader (Ubuntu)
Fix Released
High
Unassigned

Bug Description

I updated the meta-release-development file for Artful, tried to upgrade to it and got this crash:

  $ do-release-upgrade -d
Checking for a new Ubuntu release
Get:1 Upgrade tool signature [836 B]
Get:2 Upgrade tool [1,289 kB]
Fetched 1,290 kB in 6s (151 kB/s)
authenticate 'artful.tar.gz' against 'artful.tar.gz.gpg'
extracting 'artful.tar.gz'
[sudo] password for bdmurray:
-L: logfile name can not start with "-" symbol

This'll need some investigation.

Related branches

lp:~rbalint/ubuntu-release-upgrader/ubuntu-release-upgrader-screen
Brian Murray: Approve
Diff: 37 lines (+9/-1)
3 files modified
DistUpgrade/DistUpgradeMain.py (+0/-1)
DistUpgrade/screenrc (+2/-0)
debian/changelog (+7/-0)
lp:ubuntu-release-upgrader
Revision history for this message
Brian Murray (brian-murray) wrote :

As a workaround one could cd into /tmp/ubuntu-release-upgrader-$generated and run ./artful. I did not receive an error message when I did that.

Changed in ubuntu-release-upgrader (Ubuntu):
importance: Undecided → High
tags: added: artful rls-aa-incoming
Revision history for this message
Brian Murray (brian-murray) wrote :

This only affects the DistUpgradeViewText frontend and the source of the problem seems to be the logfile for screen.

screenrc contains "/var/log/dist-upgrade/screenlog.%n"

and

DistUpgradeMain.py calls screen with "-L" but no log file name. I'm pretty sure this used to work on upgrades from Y to Z. While passing the log file name to the -L switch works, there may be a better solution e.g. making sure screenrc is sourced or finding out if there is a bug in screen.

Revision history for this message
Brian Murray (brian-murray) wrote :

It did work on upgrades from Y to Z.

Brian Murray (brian-murray)
summary: - upgrade from Zesty to Artful fails
+ upgrade from Zesty to Artful fails if done in text mode
Balint Reczey (rbalint)
Changed in ubuntu-release-upgrader (Ubuntu):
assignee: nobody → Balint Reczey (rbalint)
Revision history for this message
Balint Reczey (rbalint) wrote :

From screen 4.5.0 "-L" takes an optional argument, the logfile name which can't be started with "-":
https://anonscm.debian.org/cgit/collab-maint/screen.git/commit/?h=upstream&id=80906f833dd5f1f5fb2ceb99575a289e97caca8a

Zesty has 4.5.x, Yaketty had 4.4.x thus the upgrade just started failing.
The fix needs to support upgrade from Xenial (screen 4.3.x) and Artful (screen > 4.5), too, thus needs to support both original and new screen command line.

Balint Reczey (rbalint)
Changed in ubuntu-release-upgrader (Ubuntu):
status: New → In Progress
Balint Reczey (rbalint)
Changed in ubuntu-release-upgrader (Ubuntu):
status: In Progress → Confirmed
Revision history for this message
Balint Reczey (rbalint) wrote :

An other workaround to make the upgrade pass is removing the screen package in advance.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in screen (Ubuntu):
status: New → Confirmed
Balint Reczey (rbalint)
Changed in ubuntu-release-upgrader (Ubuntu):
status: Confirmed → Fix Committed
assignee: Balint Reczey (rbalint) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-release-upgrader - 1:17.10.2

---------------
ubuntu-release-upgrader (1:17.10.2) artful; urgency=medium

  [ Balint Reczey ]
  * Turn on screen's logging in screenrc instead of via command line because
    the command line syntax is changed in screen 4.5.0 (LP: #1686117)

 -- Brian Murray <email address hidden> Wed, 03 May 2017 09:11:48 -0700

Changed in ubuntu-release-upgrader (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Do we need to patch screen too?

Changed in screen (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
Brian Murray (brian-murray) wrote :

No, we do not.

Changed in screen (Ubuntu):
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.